Skip to content

fix(bigtable): resolve check-then-act race condition in VRpcImpl #13196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 1 commit into from
May 14, 2026
Merged

fix(bigtable): resolve check-then-act race condition in VRpcImpl #13196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...d-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/session/VRpcImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,16 @@ public void start(ReqT req, VRpcCallContext ctx, VRpcListener<RespT> listener) {
Status status;
boolean retryable = true;

if (state.get() != State.NEW) {
if (!state.compareAndSet(State.NEW, State.STARTED)) {
status = Status.INTERNAL.withDescription("VRpc already started in state: " + state.get());
retryable = false;
} else if (ctx.getOperationInfo().getDeadline().timeRemaining(TimeUnit.MICROSECONDS)
< TimeUnit.MILLISECONDS.toMicros(1)) {
// transitioning to the close state is handled below
state.set(State.STARTED);
// Don't send RPCs that don't have any hope of succeeding
status =
Status.DEADLINE_EXCEEDED.withDescription("Remaining deadline is too short to send RPC");
retryable = false;
} else {
state.set(State.STARTED);
Metadata vRpcMetadata =
Metadata.newBuilder()
.setAttemptNumber(ctx.getOperationInfo().getAttemptNumber())
Expand Down
Loading