chore: adjust download-maven-plugin usages to reduce release flakiness#13272
chore: adjust download-maven-plugin usages to reduce release flakiness#13272whowes wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures a custom cacheDirectory for the download-maven-plugin across several POM files. The reviewer pointed out that because <overwrite>true</overwrite> is already set in these configurations, caching is redundant. It is recommended to use <skipCache>true</skipCache> instead of setting a custom cache directory to simplify the configuration and avoid potential cache locking issues.
| <cacheDirectory> | ||
| ${project.build.directory}/download-cache | ||
| </cacheDirectory> |
There was a problem hiding this comment.
Since <overwrite>true</overwrite> is configured, the plugin is already instructed to always download the latest version and overwrite the existing file, making caching completely redundant. Instead of configuring a custom cacheDirectory (which is deleted on mvn clean anyway), you can completely disable caching for this execution using <skipCache>true</skipCache>. This avoids any cache locking issues and simplifies the configuration.
<skipCache>true</skipCache>
| <cacheDirectory> | ||
| ${project.build.directory}/download-cache | ||
| </cacheDirectory> |
There was a problem hiding this comment.
Since <overwrite>true</overwrite> is configured, the plugin is already instructed to always download the latest version and overwrite the existing file, making caching completely redundant. Instead of configuring a custom cacheDirectory (which is deleted on mvn clean anyway), you can completely disable caching for this execution using <skipCache>true</skipCache>. This avoids any cache locking issues and simplifies the configuration.
<skipCache>true</skipCache>
| <cacheDirectory> | ||
| ${project.build.directory}/download-cache | ||
| </cacheDirectory> |
There was a problem hiding this comment.
Since <overwrite>true</overwrite> is configured, the plugin is already instructed to always download the latest version and overwrite the existing file, making caching completely redundant. Instead of configuring a custom cacheDirectory (which is deleted on mvn clean anyway), you can completely disable caching for this execution using <skipCache>true</skipCache>. This avoids any cache locking issues and simplifies the configuration.
<skipCache>true</skipCache>
There was a problem hiding this comment.
The changes look correct and effectively address the cache locking issue by setting <skipCache>true</skipCache> while maintaining the necessary overwrite behavior. This configuration is cleaner and avoids potential issues with shared cache directories in parallel build environments.
whowes
changed the title
whowes
changed the title
whowes
force-pushed
the
whowes/issue-13026-maven
branch
from
a7189e4 to
ba94110
Compare
whowes
changed the title
There was a problem hiding this comment.
I'm kind of surprised that it just worked. I though there might be additional configurations needed in the poms. I guess the existing protoc configurations automatically generates everything in main/proto.
Also I think this gapic_metadata.proto probably needs a separate solution because it is a googleapis proto and used in production code not tests. For example, we may want to use automations to sync it from googleapis to java-common-protos.
That being said, for the scope of this PR, I think it's better to still use wget to get the latest gapic_metadata from googleapis and set skipCache to true.
There was a problem hiding this comment.
SGTM - I restored wget + compilation for gapic_metadata.proto and reverted the checked-in copy. The restored download execution now has skipCache and overwrite set, mirroring what's done for showcase.
whowes
force-pushed
the
whowes/issue-13026-maven
branch
2 times, most recently
from
99db7a3 to
7d7aa93
Compare
whowes
force-pushed
the
whowes/issue-13026-maven
branch
from
7d7aa93 to
08b090c
Compare
|
|
2 participants
As observed in issue #13026, the download-maven-plugin's wget goal is currently flaky in release jobs.
This change
Fixes #13026