chore: add DEV workflow instructions for librarian#13277
Conversation
Adds instructions on: - How to find the Librarian on-call schedule and support contacts - Review and approval requirements for librarian.yaml changes - How to run Librarian locally to test changes to the generator or librarian.yaml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates sdk-platform-java/DEVELOPMENT.md to add documentation for the Client Library Generation tool, Librarian. It includes contact information, review requirements, prerequisites, and step-by-step instructions for running the generator with local changes. A review comment correctly identified a typo in the prerequisites section, suggesting to change 'JD17' to 'JDK 17'.
| * **On-Call Schedule:** You can check the current on-call rotation at `go/librarian-oncall` or by checking the rotation schedule at [Librarian Rotations](https://rotations.corp.google.com/rotation/6013581851623424). | ||
| * **Email:** Reach out to `cloud-sdk-librarian-oncall@google.com`. |
There was a problem hiding this comment.
I'd put link to go/g3doc-sdk-librarian here. This central location avoids info drifting away, and I am a bit nervous putting internal emails here publictly.
| If you want to test changes to the generator (`gapic-generator-java`) or local changes to `librarian.yaml` (e.g., testing a protobuf major version bump or unmerged generator change): | ||
|
|
||
| 1. **Modify `librarian.yaml` to point to the new version.** | ||
| - If you want to point to an experimental version of the generator, you can update `local_path` to the local path you want to test. |
There was a problem hiding this comment.
I don't think this is needed. The librarian.yaml is setup pointing to snapshot from google-cloud-java local build.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
|
|
Closing to work in a draft doc. Will open new PR when ready. |
2 participants
Fixes googleapis/librarian#5497
cc @JoeWang1127 @zhumin8, PTAL, not sure about all of these (tested the workflows locally though).