feat(firestore): support object functions#16132
feat(firestore): support object functions#16132Linchin wants to merge 6 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Firestore's expression capabilities by introducing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for the map_set function in Firestore pipeline expressions, including the implementation, a system test, and a unit test. The changes are well-structured and the tests cover the new functionality appropriately. I have one minor suggestion to fix a typo in the docstring for consistency.
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
daniel-sanche
left a comment
There was a problem hiding this comment.
LGTM, but consider improving test coverage
| Note: | ||
| `map_set` only performs shallow updates to the map. Setting a value to `None` | ||
| will retain the key with a `None` value. To remove a key entirely, use | ||
| `map_remove`. |
There was a problem hiding this comment.
do we have a test covering this?
Uh oh!
There was an error while loading. Please reload this page.