Skip to content

chore: librarian generate pull request: 20260325T142358Z#16166

Merged
codyoss merged 1 commit intomainfrom
librarian-20260325T142358Z
Mar 25, 2026
Merged

chore: librarian generate pull request: 20260325T142358Z#16166
codyoss merged 1 commit intomainfrom
librarian-20260325T142358Z

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 25, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
feat: Update DataStoreSpec and add BoostSpec to SearchService

PiperOrigin-RevId: 886697454
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@7439b698
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Clarify project number requirement for data_store field

PiperOrigin-RevId: 886697454
Library-IDs: google-cloud-discoveryengine
Source-link: googleapis/googleapis@7439b698
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@256b575f
(exclusive) and
googleapis/googleapis@7439b698
(inclusive).

Librarian Version: v1.0.2-0.20260309131826-42ac5c451239
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c5699d10addd7c32f45569a3eddc624bf68731095922cf9db0fda5352f849bf5

@parthea parthea requested review from a team as code owners March 25, 2026 14:25
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Google Cloud Discovery Engine client library to reflect recent API changes. It introduces a new boosting specification within the DataStoreSpec for search requests, allowing users to influence search result relevance. Additionally, it clarifies a documentation detail regarding the data_store field, ensuring correct usage by specifying the requirement for a project number. These changes enhance the functionality and usability of the Discovery Engine client.

Highlights

  • API Update: Discovery Engine: The DataStoreSpec in the Discovery Engine API has been updated to include a new boost_spec field, enabling more granular control over search result boosting.
  • Documentation Clarification: The documentation for the data_store field has been clarified to explicitly state that it requires a project number, not a project ID.
  • Client Library Regeneration: The google-cloud-discoveryengine client library has been regenerated to incorporate these API changes and documentation updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google-cloud-discoveryengine client library by updating its last_generated_commit hash. The main functional change involves introducing a new boost_spec field within the DataStoreSpec in search_service.py, allowing for document boosting configurations. Additionally, the documentation for data_store paths was clarified to specify the use of project numbers. Corresponding unit tests in test_evaluation_service.py have been updated to reflect and test this new boost_spec functionality within DataStoreSpec. I have no feedback to provide.

Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codyoss codyoss merged commit 4b400fa into main Mar 25, 2026
29 checks passed
@codyoss codyoss deleted the librarian-20260325T142358Z branch March 25, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants