Skip to content

chore(librarian): update synthtool SHA#16171

Merged
parthea merged 1 commit intomainfrom
parthea-patch-11
Mar 25, 2026
Merged

chore(librarian): update synthtool SHA#16171
parthea merged 1 commit intomainfrom
parthea-patch-11

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 25, 2026

The source of truth for the "generated" README for client libraries currently lives at https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_mono_repo_library/README.rst

We recently dropped Python 3.7 and 3.8 in #16150 and #16102.

The supported Python runtimes was recently updated to reflect this change in googleapis/synthtool#2168 (commit googleapis/synthtool@96f416c).

We need to update the synthtool commit in the python librarian Dockerfile to include the new README.

@parthea parthea requested review from a team as code owners March 25, 2026 20:22
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the synthtool version pinned within the librarian Dockerfile. The primary goal is to propagate recent changes from the synthtool repository, specifically those related to Python runtime support, into the client library generation process. This ensures that documentation, such as README files, accurately reflects the currently supported Python versions after the deprecation of Python 3.7 and 3.8.

Highlights

  • Synthtool Version Update: The synthtool commit SHA in the librarian Dockerfile has been updated to 96f416c959fbe8048200b6c16000de32b352902e.
  • Python Runtime Reflection: This update ensures that the generated README files for client libraries correctly reflect the recent deprecation of Python 3.7 and 3.8 runtimes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the synthtool git commit hash in the .generator/Dockerfile. The reviewer suggests adding a comment to explain the reason for checking out this specific commit to improve maintainability and provide context for future updates.

RUN git clone https://github.com/googleapis/synthtool.git synthtool && \
cd synthtool && \
git checkout afd7725f32d522a95e964884e0fba6d0d6b4cb6a
git checkout 96f416c959fbe8048200b6c16000de32b352902e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, consider adding a comment to explain why this specific commit is being checked out. This provides valuable context for future updates.

    git checkout 96f416c959fbe8048200b6c16000de32b352902e # Update supported Python versions in README template

@parthea parthea merged commit 9b893ff into main Mar 25, 2026
29 checks passed
@parthea parthea deleted the parthea-patch-11 branch March 25, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants