Skip to content

chore: test CommonResource resource name alias#16965

Merged
ohmayr merged 2 commits intomainfrom
test-for-commonresource-name-alias
May 6, 2026
Merged

chore: test CommonResource resource name alias#16965
ohmayr merged 2 commits intomainfrom
test-for-commonresource-name-alias

Conversation

@ohmayr
Copy link
Copy Markdown
Contributor

@ohmayr ohmayr commented May 6, 2026

Add a test case for resource name alias functionality in CommonResources. This is to support #16945.

@ohmayr ohmayr requested a review from a team as a code owner May 6, 2026 16:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a unit test to verify that CLI aliases are correctly passed to file-level common resources. Review feedback identifies inconsistent spelling in the test data and points out PEP 8 style violations, specifically trailing whitespace and the absence of a trailing newline in the file.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/gapic-generator/tests/unit/schema/test_api.py (4508-4518)

medium

The spelling of 'Linnaean' is inconsistent and incorrect throughout the test (e.g., 'linneaen' on line 4508 and 'linnaen' on line 4518). It is recommended to use a consistent and correct spelling (e.g., 'linnaean') to improve code clarity and maintainability.

packages/gapic-generator/tests/unit/schema/test_api.py (4523)

medium

This line contains trailing whitespace. According to PEP 8, trailing whitespace should be avoided.

References
  1. Avoid trailing whitespace anywhere. (link)

packages/gapic-generator/tests/unit/schema/test_api.py (4525)

medium

This line contains trailing whitespace. According to PEP 8, trailing whitespace should be avoided.

References
  1. Avoid trailing whitespace anywhere. (link)

packages/gapic-generator/tests/unit/schema/test_api.py (4531)

medium

The file should end with a newline character to adhere to PEP 8 and POSIX standards.

    assert resource_msgs["nomenclature.linnaen.com/Species"].resource_type == "CustomSpecies"

References
  1. Files should end with a newline. (link)

@ohmayr ohmayr merged commit 2dedaac into main May 6, 2026
88 checks passed
@ohmayr ohmayr deleted the test-for-commonresource-name-alias branch May 6, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants