chore: test CommonResource resource name alias#16965
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a unit test to verify that CLI aliases are correctly passed to file-level common resources. Review feedback identifies inconsistent spelling in the test data and points out PEP 8 style violations, specifically trailing whitespace and the absence of a trailing newline in the file.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/gapic-generator/tests/unit/schema/test_api.py (4508-4518)
The spelling of 'Linnaean' is inconsistent and incorrect throughout the test (e.g., 'linneaen' on line 4508 and 'linnaen' on line 4518). It is recommended to use a consistent and correct spelling (e.g., 'linnaean') to improve code clarity and maintainability.
packages/gapic-generator/tests/unit/schema/test_api.py (4523)
This line contains trailing whitespace. According to PEP 8, trailing whitespace should be avoided.
References
- Avoid trailing whitespace anywhere. (link)
packages/gapic-generator/tests/unit/schema/test_api.py (4525)
This line contains trailing whitespace. According to PEP 8, trailing whitespace should be avoided.
References
- Avoid trailing whitespace anywhere. (link)
packages/gapic-generator/tests/unit/schema/test_api.py (4531)
The file should end with a newline character to adhere to PEP 8 and POSIX standards.
assert resource_msgs["nomenclature.linnaen.com/Species"].resource_type == "CustomSpecies"
References
- Files should end with a newline. (link)
Add a test case for resource name alias functionality in CommonResources. This is to support #16945.