-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(documentai-toolbox): Drop support for Python <= 3.9 #16967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chalmerlowe
wants to merge
11
commits into
main
Choose a base branch
from
feat/drop-python-3.7-3.9-google-cloud-documentai-toolbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b7b3446
feat(documentai-toolbox): update setup.py metadata and python_requires
chalmerlowe 9b80743
feat(documentai-toolbox): update Nox sessions to remove old versions
chalmerlowe 0d145be
docs(documentai-toolbox): update README and CONTRIBUTING documentation
chalmerlowe 4543bc7
feat(documentai-toolbox): update version check in __init__.py
chalmerlowe 2b0390f
test(documentai-toolbox): remove obsolete pragmas in pytest.ini
chalmerlowe 72c6153
fix(documentai-toolbox): resolve dependency conflicts for Python 3.10
chalmerlowe cf585dd
fix(documentai-toolbox): pin setuptools to 79.0.0 to avoid deprecatio…
chalmerlowe 2e8b593
chore(documentai-toolbox): update constraints file header
chalmerlowe e30487d
feat(documentai-toolbox): update lower bounds for Python 3.10 compati…
chalmerlowe fc0a6b3
feat(documentai-toolbox): settle on lowest workable bounds for storag…
chalmerlowe 109b198
chore(documentai-toolbox): remove unnecessary setuptools references i…
chalmerlowe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 22 additions & 12 deletions
34
packages/google-cloud-documentai-toolbox/testing/constraints-3.10.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,22 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # This constraints file is required for unit tests. | ||
| # List all library dependencies and extras in this file. | ||
| google-api-core | ||
| pandas | ||
| proto-plus | ||
| grpc-google-iam-v1 | ||
| google-cloud-bigquery | ||
| google-cloud-documentai | ||
| google-cloud-storage | ||
| numpy | ||
| pikepdf | ||
| # This constraints file is used to check that lower bounds | ||
| # are correct in setup.py | ||
| # List all library dependencies and extras in this file, | ||
| # pinning their versions to their lower bounds. | ||
| # For example, if setup.py has "google-cloud-foo >= 1.14.0, < 2.0.0", | ||
| # then this file should have google-cloud-foo==1.14.0 | ||
| google-api-core==2.15.0 | ||
| pandas==2.0.0 | ||
| pyarrow==15.0.0 | ||
| tabulate==0.9.0 | ||
| proto-plus==1.22.3 | ||
| grpc-google-iam-v1==0.12.6 | ||
| google-cloud-bigquery==3.14.0 | ||
| google-cloud-documentai==2.29.2 | ||
| google-cloud-storage==2.3.0 | ||
| google-cloud-vision==3.2.0 | ||
| numpy==1.23.5 | ||
| intervaltree==3.0.0 | ||
| pikepdf==8.0.0 | ||
| immutabledict==2.0.0 | ||
| Pillow==10.0.0 | ||
| Jinja2==3.1.0 |
17 changes: 0 additions & 17 deletions
17
packages/google-cloud-documentai-toolbox/testing/constraints-3.9.txt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I believe system tests only run with Python 3.12. For this specific package, there are no system tests. We can remove this line altogether
https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-documentai-toolbox/tests