chore: fix librarian regeneration check#16968
Merged
jskeet merged 1 commit intogoogleapis:mainfrom May 6, 2026
Merged
Conversation
There are two reasons we should create an issue: - Regeneration failed - Regeneration succeeded, but created a diff The previous implementation was half of one, half of the other. This separates out the two cases, creating an appropriate issue in each case. Fixes googleapis/librarian#5866
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
parthea
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two reasons we should create an issue:
The previous implementation was half of one, half of the other. This separates out the two cases, creating an appropriate issue in each case.
Fixes googleapis/librarian#5866