chore: add contributing guidelines for bigframes.bigquery#16972
chore: add contributing guidelines for bigframes.bigquery#16972
Conversation
Add contributing guidelines for bigframes.bigquery APIs, detailing input and output policies, naming conventions, and examples for SQL operations.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new specification document, bigframes-bigquery-contributing.md, which defines the input and output policies for mapping BigQuery SQL functions to Python. The documentation covers type mappings, naming conventions, and provides examples for PIVOT and UNPIVOT operations. Feedback identifies several issues, including an incorrect usage example for the unpivot function, fragmented sentences in the internal expressions section, and multiple typos or formatting errors throughout the document.
| Prefer returning a `bigframes.pandas.DataFrame` that wraps a `bigframes.bigframes.core` | ||
|
|
||
|
|
||
| ``` | ||
| .bigframe_node.BigFrameNode. See from_bq_data_source in bigframes.core | ||
| ``` | ||
|
|
||
|
|
||
| `.array_value.ArrayValue`, as an example. |
There was a problem hiding this comment.
This section appears to be fragmented with incomplete sentences and incorrect module paths (e.g., bigframes.bigframes.core). It looks like a copy-paste or formatting error occurred during the creation of this document.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
Add contributing guidelines for bigframes.bigquery APIs, detailing input and output policies, naming conventions, and examples for SQL operations.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕