chore: add a presubmit that checks for librarian config consistency#16977
chore: add a presubmit that checks for librarian config consistency#16977parthea merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates librarian.yaml to set skip_release: true for the bigframes, google-cloud-storage, and google-crc32c libraries. The review highlights that the PR description mentions a new presubmit check that is currently missing from the implementation. Additionally, it is recommended to maintain consistent field ordering for skip_release across all library entries and to document configuration explanations in config.yaml rather than using comments in librarian.yaml, as those comments are not preserved during serialization.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates librarian.yaml to include skip_release: true for the bigframes, google-crc32c, and google-cloud-storage libraries. The review identifies that the implementation for the presubmit check described in the PR is missing from the changes. Additionally, there is a suggestion to move the skip_release field to maintain consistency with other entries and a note regarding the lack of comment preservation in this file.
|
I won't have time to address these comments today - and I'm on vacation tomorrow. Will come back to this on Monday. |
|
(I'd note that whatever change we do make here, we probably want to do the same in google-cloud-go as well, which this was basically copied from...) |
|
Actually, it looks like the go version is already a bit different, including using |
jskeet
force-pushed
the
config-check-presubmit
branch
from
f893a3e to
61d3a27
Compare
Currently we're using librarian for generation and legacylibrarian for releasing. This check makes sure that the relevant aspects of the two configurations (which libraries are configured, their versions, and whether releases are blocked) are consistent. This commit also ensures that we're starting from a consistent state.
jskeet
force-pushed
the
config-check-presubmit
branch
from
f9e2f68 to
0153a3a
Compare
|
@parthea I've rebased this to a single commit after doing a bunch of testing. It's ready for review now, see https://github.com/jskeet/google-cloud-python/actions/runs/25506515696 as an example of a failure. |
|
@jskeet Could we mark the presubmit as a required check? |
2 participants
Currently we're using librarian for generation and legacylibrarian for releasing. This check makes sure that the relevant aspects of the two configurations (which libraries are configured, their versions, and whether releases are blocked) are consistent.
This commit also ensures that we're starting from a consistent state.