Skip to content

test: remove pandas version restrictions and fix precision issue #17005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chalmerlowe wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

test: remove pandas version restrictions and fix precision issue #17005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a19aea0
test: remove pandas version restrictions and fix precision issue
chalmerlowe May 8, 2026
73e7c77
fix: add mypy ignore for optional pyarrow import in table and helpers
chalmerlowe May 8, 2026
93b6f8d
fix: catch ImportError in get_progress_bar and remove matplotlib skip…
chalmerlowe May 8, 2026
ba7532f
test: fix magics tests in prerelease by mocking context
chalmerlowe May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-bigquery/google/cloud/bigquery/_pyarrow_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
try:
import pyarrow # type: ignore
except ImportError:
pyarrow = None
pyarrow = None # type: ignore[assignment]

try:
import db_dtypes # type: ignore
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-bigquery/google/cloud/bigquery/_tqdm_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def get_progress_bar(progress_bar_type, description, total, unit):
)
elif progress_bar_type == "tqdm_gui":
return tqdm.tqdm_gui(desc=description, total=total, unit=unit)
except (KeyError, TypeError): # pragma: NO COVER
except (KeyError, TypeError, ImportError): # pragma: NO COVER
# Protect ourselves from any tqdm errors. In case of
# unexpected tqdm behavior, just fall back to showing
# no progress bar.
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-bigquery/google/cloud/bigquery/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
try:
import pyarrow # type: ignore
except ImportError:
pyarrow = None
pyarrow = None # type: ignore[assignment]

try:
import db_dtypes # type: ignore
Expand Down
1 change: 0 additions & 1 deletion packages/google-cloud-bigquery/tests/system/test_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,6 @@ def test_list_rows_max_results_w_bqstorage(bigquery_client):
assert len(dataframe.index) == 100


@pytest.mark.skipif(PANDAS_INSTALLED_VERSION[0:2] not in ["0.", "1."], reason="")
@pytest.mark.parametrize(
("max_results",),
(
Expand Down
4 changes: 2 additions & 2 deletions packages/google-cloud-bigquery/tests/unit/test__pandas_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,15 +551,15 @@ def test_bq_to_arrow_array_w_nullable_scalars(module_under_test, bq_type, rows):
],
)
@pytest.mark.skipif(pandas is None, reason="Requires `pandas`")
@pytest.mark.skipif(PANDAS_INSTALLED_VERSION[0:2] not in ["0.", "1."], reason="")
@pytest.mark.skipif(isinstance(pyarrow, mock.Mock), reason="Requires `pyarrow`")
def test_bq_to_arrow_array_w_pandas_timestamp(module_under_test, bq_type, rows):
rows = [pandas.Timestamp(row) for row in rows]
series = pandas.Series(rows)
bq_field = schema.SchemaField("field_name", bq_type)
arrow_array = module_under_test.bq_to_arrow_array(series, bq_field)
roundtrip = arrow_array.to_pandas()
assert series.equals(roundtrip)
series = series.astype(roundtrip.dtype)
pandas.testing.assert_series_equal(series, roundtrip)
Comment on lines +561 to +562
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While pandas.testing.assert_series_equal provides better diagnostic information than Series.equals(), it is stricter and validates the name attribute by default. Since series is initialized without a name (line 557) and roundtrip might have a name assigned during the Arrow-to-Pandas conversion (e.g., from bq_field.name), this assertion may fail. Adding check_names=False ensures the test continues to focus on value equality, maintaining consistency with the previous equals() check.

Suggested change
series = series.astype(roundtrip.dtype)
pandas.testing.assert_series_equal(series, roundtrip)
series = series.astype(roundtrip.dtype)
pandas.testing.assert_series_equal(series, roundtrip, check_names=False)



@pytest.mark.skipif(pandas is None, reason="Requires `pandas`")
Expand Down
32 changes: 22 additions & 10 deletions packages/google-cloud-bigquery/tests/unit/test_magics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@
pandas = pytest.importorskip("pandas")


@pytest.fixture()
def use_local_magics_context(monkeypatch):
if magics is not None:
local_context = magics.Context()
local_context._project = "unit-test-project"
mock_credentials = mock.create_autospec(
google.auth.credentials.Credentials, instance=True
)
local_context._credentials = mock_credentials
monkeypatch.setattr(magics, "context", local_context)


@pytest.fixture(scope="session")
def ipython():
config = tools.default_config()
Expand Down Expand Up @@ -523,7 +535,7 @@ def test_bigquery_magic_default_connection_user_agent(monkeypatch):


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_with_legacy_sql(monkeypatch):
def test_bigquery_magic_with_legacy_sql(monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand All @@ -543,7 +555,7 @@ def test_bigquery_magic_with_legacy_sql(monkeypatch):

@pytest.mark.usefixtures("ipython_interactive")
@pytest.mark.skipif(pandas is None, reason="Requires `pandas`")
def test_bigquery_magic_with_result_saved_to_variable(ipython_ns_cleanup, monkeypatch):
def test_bigquery_magic_with_result_saved_to_variable(ipython_ns_cleanup, monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand Down Expand Up @@ -577,7 +589,7 @@ def test_bigquery_magic_with_result_saved_to_variable(ipython_ns_cleanup, monkey


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_does_not_clear_display_in_verbose_mode(monkeypatch):
def test_bigquery_magic_does_not_clear_display_in_verbose_mode(monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand All @@ -599,7 +611,7 @@ def test_bigquery_magic_does_not_clear_display_in_verbose_mode(monkeypatch):


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_clears_display_in_non_verbose_mode(monkeypatch):
def test_bigquery_magic_clears_display_in_non_verbose_mode(monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand All @@ -624,7 +636,7 @@ def test_bigquery_magic_clears_display_in_non_verbose_mode(monkeypatch):
@pytest.mark.skipif(
bigquery_storage is None, reason="Requires `google-cloud-bigquery-storage`"
)
def test_bigquery_magic_with_bqstorage_from_argument(monkeypatch):
def test_bigquery_magic_with_bqstorage_from_argument(monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand Down Expand Up @@ -691,7 +703,7 @@ def warning_match(warning):
@pytest.mark.skipif(
bigquery_storage is None, reason="Requires `google-cloud-bigquery-storage`"
)
def test_bigquery_magic_with_rest_client_requested(monkeypatch):
def test_bigquery_magic_with_rest_client_requested(monkeypatch, use_local_magics_context):
pandas = pytest.importorskip("pandas")

ip = IPython.get_ipython()
Expand Down Expand Up @@ -1437,7 +1449,7 @@ def test_bigquery_magic_with_project(monkeypatch):


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_with_bigquery_api_endpoint(ipython_ns_cleanup, monkeypatch):
def test_bigquery_magic_with_bigquery_api_endpoint(ipython_ns_cleanup, monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand All @@ -1460,7 +1472,7 @@ def test_bigquery_magic_with_bigquery_api_endpoint(ipython_ns_cleanup, monkeypat


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_with_bigquery_api_endpoint_context_dict(monkeypatch):
def test_bigquery_magic_with_bigquery_api_endpoint_context_dict(monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand All @@ -1484,7 +1496,7 @@ def test_bigquery_magic_with_bigquery_api_endpoint_context_dict(monkeypatch):


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_with_bqstorage_api_endpoint(ipython_ns_cleanup, monkeypatch):
def test_bigquery_magic_with_bqstorage_api_endpoint(ipython_ns_cleanup, monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand All @@ -1507,7 +1519,7 @@ def test_bigquery_magic_with_bqstorage_api_endpoint(ipython_ns_cleanup, monkeypa


@pytest.mark.usefixtures("ipython_interactive")
def test_bigquery_magic_with_bqstorage_api_endpoint_context_dict(monkeypatch):
def test_bigquery_magic_with_bqstorage_api_endpoint_context_dict(monkeypatch, use_local_magics_context):
ip = IPython.get_ipython()
monkeypatch.setattr(bigquery, "bigquery_magics", None)
bigquery.load_ipython_extension(ip)
Expand Down
1 change: 0 additions & 1 deletion packages/google-cloud-bigquery/tests/unit/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4092,7 +4092,6 @@ def test_to_dataframe_no_tqdm(self):

def test_to_dataframe_tqdm_error(self):
pytest.importorskip("pandas")
pytest.importorskip("matplotlib")
tqdm = pytest.importorskip("tqdm")
mock.patch("tqdm.tqdm_gui", new=None)
mock.patch("tqdm.notebook.tqdm", new=None)
Expand Down
Loading