feat(bigtable): classic direct access checker and it's implementation by sushanb · Pull Request #2840 · googleapis/java-bigtable

sushanb · 2026-03-12T16:03:13Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Rollback plan is reviewed and LGTMed
All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

...cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/MetricsImpl.java

...cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/DirectAccessChecker.java

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/UnaryDirectAccessChecker.java

...ud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelFactory.java

...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/UnaryDirectAccessChecker.java

nimf

First comments from the first pass. Will do another pass soon.

nimf · 2026-03-24T21:22:27Z

...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java

+
+    InstantiatingGrpcChannelProvider selectedProvider;
+
+    if (isDirectAccessEligible) {


don't we also need to check if the user disabled directpath using CBT_ENABLE_DIRECTPATH=false?

nimf · 2026-03-24T21:24:35Z

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

-              .setDirectAccessRequested(DIRECT_PATH_ENABLED)
-              .setTrafficDirectorEnabled(DIRECT_PATH_ENABLED)
+              .setDirectAccessRequested(DIRECT_PATH_ENABLED || enableDirectPathByDefault)
+              .setTrafficDirectorEnabled(DIRECT_PATH_ENABLED || enableDirectPathByDefault)


if the user disabled directpath using CBT_ENABLE_DIRECTPATH=false this will still yield true if it was enabled by default.

sushanb requested a review from igorbernstein2 March 12, 2026 16:03

sushanb requested review from a team as code owners March 12, 2026 16:03

product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 12, 2026