Removing cameras list entry from control center #4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the cameras list control widget from the iOS Control Center for production builds while maintaining it for development/debugging purposes. This change aligns the app with Home Assistant's frontend team's preference for centralized management of dashboard-like UI elements.
Changes:
- Moved
ControlOpenCamerasList()from the production widget bundle to the DEBUG-only section
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4211 +/- ##
=======================================
Coverage ? 44.85%
=======================================
Files ? 250
Lines ? 14414
Branches ? 0
=======================================
Hits ? 6466
Misses ? 7948
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since it conflicts with Home Assistant frontend interests in managing "dashboard-like" UI, I'm removing the access to cameras list for now until we have a final decision over it.
Contributors can still access it while debugging in Xcode.
CC: @frenck
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes