Fix thread safety for hasStarted flag in CameraMJPEGPlayerViewModel #4215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Address feedback on simplify CameraView MPEG PR
Fix thread safety for hasStarted flag in CameraMJPEGPlayerViewModel
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses thread safety issue where
hasStartedflag was being modified from background threads despite@MainActorannotation on the class.Changes:
hasStarted = falseassignment in error handler withstop()call to ensure flag modification happens on main threadhasStartedmodifications now properly dispatched to main thread viaDispatchQueue.main.asyncor through@MainActormethodsScreenshots
N/A - Internal state management change with no UI impact
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
This is a stacked PR that merges into #4213 to address review feedback from #4213 (comment)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.