fix: handle LoKr format keys in Z-image LoRA conversion#13250
Open
s-zx wants to merge 1 commit intohuggingface:mainfrom
Open
fix: handle LoKr format keys in Z-image LoRA conversion#13250s-zx wants to merge 1 commit intohuggingface:mainfrom
s-zx wants to merge 1 commit intohuggingface:mainfrom
Conversation
The _convert_non_diffusers_z_image_lora_to_diffusers function did not consume LoKr-format keys (.lokr_w1, .lokr_w2, .alpha) from external Z-image LoRA checkpoints (e.g. Kohya/LyCORIS), causing a ValueError when the state_dict was not empty after conversion. Add handling to convert LoKr decomposition to standard lora_A/lora_B format: for linear layers, lokr_w1 @ lokr_w2 maps to lora_B @ lora_A with the same alpha scaling used by other formats. Fixes huggingface#13221 Signed-off-by: s-zx <s-zx@users.noreply.github.com>
Member
|
HI @s-zx, can you show an example image of a lokr that works with this? I mean the original somewhere where it works versus this PR? It would also help to have the actual lokr in the hub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
_convert_non_diffusers_z_image_lora_to_diffusersfunction did not consume LoKr-format keys (.lokr_w1,.lokr_w2,.alpha) from external Z-image LoRA checkpoints (e.g. Kohya/LyCORIS), causing aValueErrorwhen the state_dict was not empty after conversion.Root Cause
The conversion function handled standard LoRA formats (lora_down/lora_up, lora_A/lora_B, lora.down/up) but lacked handling for LoKr decomposition format used by some trainers.
Fix
Add handling to convert LoKr decomposition to standard lora_A/lora_B format: for linear layers,
lokr_w1 @ lokr_w2maps tolora_B @ lora_Awith the same alpha scaling. The conversion applies the standard alpha/rank scaling used by other formats.Fixes #13221