Align run utility signature with python sdk #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+288
to
+290
| const evaluatorsWithCallable = evaluators.filter( | ||
| (e) => e.callable !== undefined, | ||
| ); |
Contributor
There was a problem hiding this comment.
this could potentially break existing callers, right? What if someone is explicitly passing callable: null?
Author
There was a problem hiding this comment.
I think it's well handled, the problem was that we could not specify an online evaluator
Comment on lines
+94
to
+96
| callable?: Function; | ||
| /**The type of arguments the Evaluator expects - only required for local Evaluators.*/ | ||
| argsType?: EvaluatorArgumentsType; |
Contributor
There was a problem hiding this comment.
I suspect we should/could do some stronger typing here where we can statically check if a passed evaluator is either a remote evaluator (path/id) or local one.
Author
There was a problem hiding this comment.
true, evaluator could be a union where you either provide a path or {callable, argsType, returnType}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.