Add support for both wasmtime latest (39.x) and LTS (36.x) versions#301
Open
jsturtevant wants to merge 2 commits intohyperlight-dev:mainfrom
Open
Add support for both wasmtime latest (39.x) and LTS (36.x) versions#301jsturtevant wants to merge 2 commits intohyperlight-dev:mainfrom
jsturtevant wants to merge 2 commits intohyperlight-dev:mainfrom
Conversation
jsturtevant
force-pushed
the
update-wasmtime
branch
7 times, most recently
from
ae7ec12 to
165ceab
Compare
Contributor
|
LGTM, but shouldn't default be LTS? Otherwise it would be a break change. Or maybe that's what we want? |
ludfjig
reviewed
Dec 17, 2025
Comment on lines
+22
to
+35
| // Re-export wasmtime based on expected version | ||
| #[cfg(all(feature = "wasmtime_latest", feature = "wasmtime_lts"))] | ||
| compile_error!( | ||
| "Features 'wasmtime_latest' and 'wasmtime_lts' are mutually exclusive. Please enable only one." | ||
| ); | ||
|
|
||
| #[cfg(not(any(feature = "wasmtime_latest", feature = "wasmtime_lts")))] | ||
| compile_error!("Either 'wasmtime_latest' or 'wasmtime_lts' feature must be enabled."); | ||
|
|
||
| #[cfg(not(feature = "wasmtime_lts"))] | ||
| extern crate wasmtime; | ||
| #[cfg(feature = "wasmtime_lts")] | ||
| extern crate wasmtime_lts as wasmtime; | ||
|
|
Contributor
There was a problem hiding this comment.
Is there any value in making these not mutually exclusive? If both are enabled, we could default to one of them, similar to mshv and mshv3 used to work in hyperlight. I think mutually exclusive features are generally discouraged
Contributor
Author
There was a problem hiding this comment.
I didn't think there was any value in having both. I did default to one in the cargo.toml so that the users wouldn't need to choose. If its discouraged I could try it with both
Contributor
Author
I don't think it is a breaking change, just a decency bump. My thought was that most WASM users would want to the latest wasmtime. |
jsturtevant
force-pushed
the
update-wasmtime
branch
3 times, most recently
from
57528c8 to
84d5c03
Compare
Introduces wasmtime_lts feature flag to switch between wasmtime versions. Default uses latest (39.0.1), pass --lts flag to AOT compiler or enable wasmtime_lts feature for LTS version (36.0.3). CI updated to test both. Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
jsturtevant
force-pushed
the
update-wasmtime
branch
from
4c8fece to
5af7655
Compare
The pulley feature was only forwarded to the latest wasmtime dep via wasmtime?/pulley. When building with wasmtime_lts, the pulley feature on the LTS wasmtime crate was not enabled, causing the runtime to execute pulley-compiled AOT code as native x86 (InvalidOpcode). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces wasmtime_lts feature flag to switch between wasmtime versions.
Default uses latest (39.0.1), pass --lts flag to AOT compiler for LTS version (36.0.3). CI updated to test both.