remove cargo-overlay#448
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to stop using cargo-overlay-registry for crates.io publishing, replacing it with a conditional “publish if version isn’t already on crates.io” approach to avoid failures seen in recent release runs.
Changes:
- Removed installation and usage of
cargo-overlay-registryfrom the release publish workflow. - Added a bash helper (
publish_if_needed) that checks crates.io for an existing version before runningcargo publishper crate. - Publishes the workspace crates in an explicit sequence (macro → runtime → aot → main crate).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simongdavies
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't work as can be seen in most recently https://github.com/hyperlight-dev/hyperlight-wasm/actions/runs/24151621001
Also makes the job able to rerun if it failed in the middle of publishing some crates, in which case it will not try to republish same version again