-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(messaging, ios): prioritize delegate call order in willPresentNotification #8786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(messaging, ios): prioritize delegate call order in willPresentNotification #8786
Conversation
|
@wrtn-wontak is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi there @WontakKim looks good to me just fix the linter issues please and I will approve it and ensure the CLA is signed. |
|
Hi @MichaelVerdon, I've signed the CLA docs and ran |
38a52cd to
7af280b
Compare
|
Hi @MichaelVerdon , kindly reminds you to review this PR. Thanks. |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Hi @MichaelVerdon , It's been a while since I left my last comment, but I haven't received any response yet. Could you please check on this? |
Description
This PR fixes an issue where
completionHandlerinuserNotificationCenter:willPresentNotification:withCompletionHandler:is called before the original delegate, preventing custom foreground notification presentation logic from working.Related issues
#8754
Release Summary
Fixed iOS messaging to respect custom notification presentation logic by calling the original delegate before consuming the completionHandler.
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Tested Scenario:
willPresentNotificationhandler in AppDelegate to control notification presentationBefore Fix:
After Fix:
Code Example Tested: