-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(item-divider): add recipe and tokens #31009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thetaPC
wants to merge
47
commits into
ionic-modular
Choose a base branch
from
FW-6841
base: ionic-modular
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
20a4a33
feat(item-divider): add recipe and tokens
thetaPC 8295819
chore(): run build
thetaPC 38145a3
chore(item-divider): remove theme sass files
thetaPC e2cf0e4
feat(item-divider): remove theme usage
thetaPC 4b170f0
docs(item-divider): add todo for border
thetaPC c66561e
refactor(tokens): rearrange shared tokens
thetaPC fda52f5
docs(tokens): update shared file comments
thetaPC eac584c
test(item): update divider snapshots
thetaPC 87e6443
test(item): update divider snapshots again
thetaPC d9db79f
docs(item-divider, thumbnail): update todo
thetaPC 6260629
docs(item-divider): update comments
thetaPC fd9f0b5
feat(item-divider): revert-layer note font size
thetaPC 77e50df
feat(item-divider): add interface
thetaPC 3336859
feat(item-divider): cleanup
thetaPC 89bcfb4
revert(chip): import usage
thetaPC fc0b992
feat(item-divider): more cleanup
thetaPC 226beaa
refactor(theme): move baseline pixel
thetaPC 88bfce3
refactor(theme): update dynamicFont to use root
thetaPC a9f991b
fix(theme): check window
thetaPC be24a41
feat(item-divider): use note align self token
thetaPC 8595353
feat(theme): use baseColor token
thetaPC bd9f016
refactor(themes): pass the root to dynamicFont
thetaPC ac44338
fix(item-divider): add line-height back
thetaPC 02515ef
docs(item-divider): remove comment
thetaPC fd73b43
feat(themes): improve on slot keys
thetaPC 1c72a1e
chore(): run lint
thetaPC b9c7961
feat(chip, item-divider): clarify leading, trailing
thetaPC e7233e1
docs(themes): remove extra comments
thetaPC 6266f82
feat(item-divider): remove old CSS variables
thetaPC 5a07815
chore(): run lint
thetaPC 6ed2661
docs(BREAKING): add item divider
thetaPC 05092db
chore(): run build
thetaPC 5b54221
docs(item-divider): add new CSS variable docs
thetaPC a4443a5
chore(): run lint
thetaPC 9af22f8
docs(item-divider): replace underscore
thetaPC 02f96ba
Merge branch 'ionic-modular' of github.com:ionic-team/ionic-framework…
thetaPC f2b6393
chore(chip): remove unused use import
thetaPC 8a9a4b4
revert(theme): import order
thetaPC 918ecbe
feat(item-divider): remove heading styles
thetaPC fc978e8
refactor(item-divider): remove border radius
thetaPC 6e66739
refactor(item-divider): remove margin
thetaPC ed648e0
refactor(item-divider): remove quotes
thetaPC 057bb0e
Merge branch 'ionic-modular' of github.com:ionic-team/ionic-framework…
thetaPC faf287a
feat(item-divider): update key names
thetaPC d676a91
feat(chip): update key names
thetaPC 36eb167
revert(item-divider): remove extra space
thetaPC d001758
chore(): run build
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
161 changes: 161 additions & 0 deletions
161
core/src/components/item-divider/item-divider.interfaces.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| import type { IonPadding, IonMargin } from '../../themes/themes.interfaces'; | ||
|
|
||
| export type IonItemDividerRecipe = { | ||
| background?: string; | ||
| color?: string; | ||
| minHeight?: string; | ||
|
|
||
| padding?: IonPadding; | ||
|
|
||
| inner?: { | ||
| padding?: IonPadding; | ||
| }; | ||
|
|
||
| border?: { | ||
| bottom?: string; | ||
| }; | ||
|
|
||
| font?: { | ||
| size?: string; | ||
| weight?: string; | ||
| }; | ||
|
|
||
| /** Targets `[slot="start"]` */ | ||
| start?: { | ||
| /** Targets `::slotted([slot="start"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `[slot="end"]` */ | ||
| end?: { | ||
| /** Targets `::slotted([slot="end"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(ion-label)` */ | ||
| label?: { | ||
| margin?: IonMargin; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(ion-icon)` */ | ||
| icon?: { | ||
| font?: { | ||
| size?: string; | ||
| }; | ||
|
|
||
| /** Targets `[slot="start"]` */ | ||
| start?: { | ||
| /** Targets `::slotted(ion-icon[slot="start"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `[slot="end"]` */ | ||
| end?: { | ||
| /** Targets `::slotted(ion-icon[slot="end"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| /** Default non-semantic states */ | ||
| default?: { | ||
| color?: string; | ||
| }; | ||
|
|
||
| /** Any of the semantic colors like primary, secondary, etc. */ | ||
| semantic?: { | ||
| default?: { | ||
| color?: string; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(ion-note)` */ | ||
| note?: { | ||
| align?: { | ||
| self?: string; | ||
| }; | ||
|
|
||
| font?: { | ||
| size?: string; | ||
| }; | ||
|
|
||
| margin?: IonMargin; | ||
| padding?: IonPadding; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(ion-avatar)` */ | ||
| avatar?: { | ||
| height?: string; | ||
| width?: string; | ||
|
|
||
| margin?: IonMargin; | ||
|
|
||
| /** Targets `[slot="start"]` */ | ||
| start?: { | ||
| /** Targets `::slotted(ion-avatar[slot="start"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `[slot="end"]` */ | ||
| end?: { | ||
| /** Targets `::slotted(ion-avatar[slot="end"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(ion-thumbnail)` */ | ||
| thumbnail?: { | ||
| height?: string; | ||
| width?: string; | ||
|
|
||
| margin?: IonMargin; | ||
|
|
||
| /** Targets `[slot="start"]` */ | ||
| start?: { | ||
| /** Targets `::slotted(ion-thumbnail[slot="start"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `[slot="end"]` */ | ||
| end?: { | ||
| /** Targets `::slotted(ion-thumbnail[slot="end"])` */ | ||
| slotted?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(p)` */ | ||
| paragraph?: { | ||
| color?: string; | ||
| overflow?: string; | ||
|
|
||
| margin?: IonMargin; | ||
|
|
||
| font?: { | ||
| size?: string; | ||
| }; | ||
|
|
||
| text?: { | ||
| overflow?: string; | ||
| }; | ||
|
|
||
| /** Targets `::slotted(p:last-child)` */ | ||
| trailing?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This follows the same structure established in chip when it came to default vs semantic colors.