feat(content): add recipe and tokens by thetaPC · Pull Request #31095 · ionic-team/ionic-framework

thetaPC · 2026-04-24T23:04:37Z

Issue number: resolves internal

What is the current behavior?

ion-content does not fragment styles based on themes. All 3 themes share one style. However, it's not configured to the Modular Ionic.

What is the new behavior?

Defined TypeScript Interface: Renamed content-interface.ts to content.interfaces.ts and added IonContentRecipe type.
Defined Theme Defaults: Added per-theme token defaults in ios, md, and ionic theme files.
Internal Variable Prefix: Renamed --offset-top / --offset-bottom to --internal-offset-top / --internal-offset-bottom to clearly separate them from the public CSS API.
CSS Logical Properties for RTL: Replaced physical-property RTL selectors on .transition-effect and .transition-shadow with the position-horizontal mixin.
Removed dead property: Dropped -webkit-overflow-scrolling: touch from styles as this property has been a no-op since iOS 13.
Updated Tests: Added unit specs for transitionShadow (present in ios mode, absent in md mode) and the getScrollElement() / getBackgroundElement() element ref methods.
New utility: Replaced inline new Promise((resolve) => componentOnReady(...)) patterns with a shared waitForComponent helper, reducing boilerplate and improving type safety.

Does this introduce a breaking change?

Yes
No

This PR introduces breaking changes to how ion-content is styled.

Migration Path:

CSS Variable Replacements: --background and --color have been removed. Use the new token structure:

--background -> IonContent.background
--color -> IonContent.color

--padding-* is still supported. .ion-padding, .ion-padding-* classes in css/padding.scss set --padding-* directly on the host. ion-content continues to honor those values (falling back to the new token when unset). Existing usage of the utility classes and direct --padding-* overrides will keep working.

New code is encouraged to use the token-based API instead:

--padding-top -> IonContent.padding.top
--padding-end -> IonContent.padding.end
--padding-bottom -> IonContent.padding.bottom
--padding-start -> IonContent.padding.start

Note: core/api.txt only lists the new --ion-content-padding-* variables. The --padding-* overrides remain functional but are no longer part of the documented public API.

If per-component customization is needed, the CSS variables can be used directly.

--background -> --ion-content-background
--color -> --ion-content-color
--padding-top -> --ion-content-padding-top
--padding-end -> --ion-content-padding-end
--padding-bottom -> --ion-content-padding-bottom
--padding-start -> --ion-content-padding-start

Internal-only variables (no replacement): The following CSS variables were previously documented @props on ion-content and have been renamed to the --internal-* namespace, removing them from the public API:

--keyboard-offset -> --internal-keyboard-offset
--offset-top      -> --internal-offset-top
--offset-bottom   -> --internal-offset-bottom

These are managed by ion-content itself (keyboard avoidance and header/footer offsets) and were never intended for consumer override. There is no replacement - any code that was setting them directly should be removed.

Theme classes: Remove any instances that target the theme classes: ion-content.md, ion-content.ios.

Other information

Previews:

The framework (Angular, React, Vue) test apps are not being styled correctly anymore because the new tokens are not being passed to them. This is expected until we can export the tokens as mentioned in the design doc. The functionality in those test apps are still working.

vercel · 2026-04-24T23:04:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
ionic-framework	Ready	Preview, Comment	May 6, 2026 11:19pm

thetaPC · 2026-04-30T17:50:58Z

  flex-shrink: 2;
  overscroll-behavior-y: contain;
  overflow-y: auto;
-  -webkit-overflow-scrolling: touch;


-webkit-overflow-scrolling has become obsolete since iOS 13.

thetaPC · 2026-04-30T17:52:32Z

  contain: size style;
 }

-:host(.ion-color) .inner-scroll {


There seems to be a lot deleted, but they were just moved around in the file.

thetaPC · 2026-04-30T17:53:08Z

  @Method()
  async getBackgroundElement(): Promise<HTMLElement> {
    if (!this.backgroundContentEl) {
-      await new Promise((resolve) => componentOnReady(this.el, resolve));


Created a util for this since a lot of components are using the same code

thetaPC · 2026-05-05T03:29:55Z

-            ...customTheme.palette,
-          },
-        };
+        theme = deepMerge(theme, customTheme);


This change mimics exactly how we are loading themes in the theme.ts file.

thetaPC · 2026-05-05T13:40:35Z

+  $padding-top: var(--padding-top, var(--ion-content-padding-top, 0px));
+  $padding-end: var(--padding-end, var(--ion-content-padding-end, 0px));
+  $padding-bottom: var(--padding-bottom, var(--ion-content-padding-bottom, 0px));
+  $padding-start: var(--padding-start, var(--ion-content-padding-start, 0px));


In order for the padding classes (.ion-padding) to still be functional, we should be incorporating them as the first check.

thetaPC · 2026-05-05T13:42:01Z

+:host(.ion-color) .inner-scroll {
+  background: color.current-color(base);
+  color: color.current-color(contrast);
+}


I didn't make this customizable because all themes are using the same styles. If the community requests it, then we can update the recipe to include it.

thetaPC · 2026-05-05T13:48:22Z

 }

 .transition-shadow {
+  @include mixins.position-horizontal(null, 0);


We can now use this mixin instead of having to use left/right!

thetaPC · 2026-05-05T18:08:58Z


+:host(.ion-color) .inner-scroll {
+  background: color.current-color(base);
+  color: color.current-color(contrast);


I was going to switch this to use foreground as stated in the ticket but that lead to unwanted changes like:

The text color is not readable in some components. Others, it's too light and I question if it would pass accessibility.

We should look into the foreground values again.

ShaneK

Looking awesome! Mostly just have a few clarafication/documentation questions

ShaneK

Looks good to me! Just a question and a nit, but non-blocking

ShaneK · 2026-05-07T16:18:10Z

   * @returns The value found at the nested key or the fallback
   */
-  getObjectValue(key: string, fallback?: string): string | undefined {
+  getObjectValue(key: string, fallback?: ObjectConfigValue): ObjectConfigValue | undefined {


Are there callers lined up that need the boolean return? I couldn't find any consumers of getObjectValue, so widening from string | undefined to string | boolean | undefined reads as pre-emptive. If a follow-up PR needs it, that's cool, just checking.

ShaneK · 2026-05-07T16:24:39Z

 }

 .transition-shadow {
+  @include mixins.position-horizontal(null, 0);


Nit: .transition-effect and .transition-shadow got converted to mixins.position-horizontal(...), but .transition-cover at line 245 still uses literal right: 0 with stylelint-disable. Full-width so RTL behavior is identical, but is leaving the asymmetric pattern intentional?

feat(content): add recipe and tokens

7afba1a

github-actions Bot added the package: core @ionic/core package label Apr 24, 2026

vercel Bot had a problem deploying to Preview April 24, 2026 23:05 Failure

thetaPC added 2 commits April 30, 2026 10:00

feat(content): cleanup

32d2fdb

feat(content): more cleanup

57c3140

github-actions Bot added the package: angular @ionic/angular package label Apr 30, 2026

vercel Bot deployed to Preview April 30, 2026 17:03 View deployment

refactor(utils): created waitForComponent

5983c3b

vercel Bot deployed to Preview April 30, 2026 17:37 View deployment

feat(styles): remove webkit-overflow-scrolling

76a32dd

vercel Bot deployed to Preview April 30, 2026 17:50 View deployment

thetaPC commented Apr 30, 2026

View reviewed changes

feat(content): improvements

7646ae6

vercel Bot deployed to Preview April 30, 2026 18:10 View deployment

feat(contenet): remove transition theme

412806f

vercel Bot deployed to Preview April 30, 2026 18:13 View deployment

refactor(contenet): update padding variables

c8f817c

vercel Bot deployed to Preview April 30, 2026 18:36 View deployment

vercel Bot deployed to Preview May 1, 2026 22:36 View deployment

vercel Bot deployed to Preview May 1, 2026 22:51 View deployment

vercel Bot deployed to Preview May 1, 2026 22:57 View deployment

github-actions Bot added the package: vue @ionic/vue package label May 1, 2026

vercel Bot deployed to Preview May 1, 2026 22:59 View deployment

vercel Bot deployed to Preview May 1, 2026 23:08 View deployment

thetaPC force-pushed the FW-6896 branch from 300abbf to c8f817c Compare May 4, 2026 13:22

github-actions Bot removed the package: vue @ionic/vue package label May 4, 2026

feat(content): remove unused config

6a496be

test(scripts): add deep merge

5d7fb5f

thetaPC commented May 5, 2026

View reviewed changes

vercel Bot deployed to Preview May 5, 2026 03:30 View deployment

feat(content): remove fallbacks when necessary

68c7136

vercel Bot deployed to Preview May 5, 2026 13:24 View deployment

feat(content): use global padding variables

dab1803

thetaPC commented May 5, 2026

View reviewed changes

vercel Bot deployed to Preview May 5, 2026 13:40 View deployment

thetaPC commented May 5, 2026

View reviewed changes

thetaPC marked this pull request as ready for review May 5, 2026 15:37

thetaPC requested a review from a team as a code owner May 5, 2026 15:37

thetaPC requested a review from gnbm May 5, 2026 15:37

thetaPC marked this pull request as draft May 5, 2026 16:58

thetaPC commented May 5, 2026

View reviewed changes

thetaPC marked this pull request as ready for review May 5, 2026 18:09

ShaneK requested changes May 6, 2026

View reviewed changes

Comment thread core/src/components/content/content.scss

Comment thread core/src/css/core.scss Outdated

Comment thread core/src/components/content/content.scss

Comment thread core/src/components/content/content.scss Outdated

Comment thread core/src/themes/ios/default.tokens.ts Outdated

docs(content): add ion-padding comment

4704cc1

vercel Bot deployed to Preview May 6, 2026 22:56 View deployment

feat(content): use new token for menu global style

94e7f36

vercel Bot deployed to Preview May 6, 2026 22:58 View deployment

docs(content): add internal variables reason

dddcd4e

vercel Bot deployed to Preview May 6, 2026 23:10 View deployment

feat(content): add a fallback for font-family

095398c

vercel Bot deployed to Preview May 6, 2026 23:16 View deployment

docs(content): add Jira ticket to TODO

32ea3b7

vercel Bot deployed to Preview May 6, 2026 23:19 View deployment

thetaPC requested review from ShaneK and removed request for gnbm May 7, 2026 00:53

ShaneK approved these changes May 7, 2026

View reviewed changes

Conversation

thetaPC commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Other information

Uh oh!

vercel Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShaneK left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShaneK left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

thetaPC commented Apr 24, 2026 •

edited

Loading

vercel Bot commented Apr 24, 2026 •

edited

Loading