fix(segment-view): prevent NaN/Infinity scrollRatio when a single content item is present#31113
Merged
OS-susmitabhowmik merged 7 commits intonextfrom May 7, 2026
Merged
Conversation
…tent item is present
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
requested changes
May 5, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Nice! Just a couple things to make this bullet-proof
…ngle content item
ShaneK
approved these changes
May 7, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding tests 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Currently if there is a single content item present the
scrollRatiois computed asNaNorInfinityresulting in a console error.What is the new behavior?
Updates
handleScrollinion-segment-viewto skiphandleScrollifmax <= 0Does this introduce a breaking change?
Other information