Skip to content

Attempting to do CI to run unit tests on all PRs.#446

Closed
LowAmmo wants to merge 60 commits into
masterfrom
kktest-ci
Closed

Attempting to do CI to run unit tests on all PRs.#446
LowAmmo wants to merge 60 commits into
masterfrom
kktest-ci

Conversation

@LowAmmo
Copy link
Copy Markdown
Collaborator

@LowAmmo LowAmmo commented Mar 19, 2026

Limiting to just iPhone for now

@LowAmmo LowAmmo marked this pull request as draft April 8, 2026 16:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

Code Coverage

Scope Coverage Status
libPhoneNumber 82.43%
libPhoneNumberGeocoding 75.86%
libPhoneNumberShortNumber 80.86%
           Combined 81.94%

@iziz iziz closed this May 12, 2026
@iziz
Copy link
Copy Markdown
Owner

iziz commented May 12, 2026

Thanks a lot for putting this together and for iterating on the CI setup.

I’m closing this PR because the CI work has been superseded by the newer maintenance/CI updates on master.

The current CI now covers the main validation paths we need for PRs and pushes:

  • SwiftPM tests
  • Korean locale SwiftPM tests
  • release build
  • upstream test/API parity checks
  • version consistency check
  • geocoding metadata updater smoke test
  • CocoaPods lint
  • Xcode scheme tests

This PR also contains a large experimental reusable-action/coverage setup and now conflicts with the updated workflow structure. Rather than merging it as-is, we should keep the current CI as the baseline.

The coverage-reporting and simulator-selection ideas are still useful. If we want to revisit them, they would be very welcome as smaller PRs based on the latest master.

Thanks again for the contribution and for helping move the project’s CI forward.

@LowAmmo
Copy link
Copy Markdown
Collaborator Author

LowAmmo commented May 12, 2026

@iziz - No worries...I was just iterating on it to try to get it working (and also experiment on using AI to help code up all the github action logic).

I saw that you went ahead and did your own thing, so yeah...I will hopefully get a chance to revise this work, and start building off of what you did to add additional features in the future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants