Skip to content

#713 include options in sortComplete#714

Open
vanboom wants to merge 1 commit into
javve:masterfrom
vanboom:master
Open

#713 include options in sortComplete#714
vanboom wants to merge 1 commit into
javve:masterfrom
vanboom:master

Conversation

@vanboom
Copy link
Copy Markdown

@vanboom vanboom commented Jan 26, 2021

The sortComplete event would be a great place to pass back the sort options.

This could also potentially close issue #689.
This facilitates potential solutions for #650.

Thank you for your consideration on this PR.

@kiehnek
Copy link
Copy Markdown

kiehnek commented Feb 7, 2021

I think the same thing should be done for the search & filter events. This would also fix point 14 on the wishlist.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.54%. Comparing base (d32c85d) to head (fd35570).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          19       19           
  Lines         837      837           
  Branches      199      199           
=======================================
  Hits          783      783           
  Misses         38       38           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants