Skip to content

Add svg icons from Django 1.9 and use static function#218

Closed
claudep wants to merge 1 commit intojazzband:masterfrom
claudep:svg_icons
Closed

Add svg icons from Django 1.9 and use static function#218
claudep wants to merge 1 commit intojazzband:masterfrom
claudep:svg_icons

Conversation

@claudep
Copy link
Copy Markdown
Collaborator

@claudep claudep commented Nov 3, 2016

Fixes #172.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 3, 2016

Coverage Status

Coverage increased (+0.03%) to 89.679% when pulling 93c0e57 on claudep:svg_icons into 323dc20 on dokterbob:master.

@dokterbob
Copy link
Copy Markdown
Collaborator

Thanks! If wait and submit aren't there yet, perhaps we should not close the SVG ticket altogether.

Any chance we could find equivalent SVG icons for these messages to fully finish this off?

@claudep
Copy link
Copy Markdown
Collaborator Author

claudep commented Mar 28, 2017

It shouldn't too hard to convert waiting.gif to svg, but submitting.gif is animated, so it's trickier to convert (don't know the status of animated SVG in current browsers).

@dkdndes
Copy link
Copy Markdown

dkdndes commented Jun 27, 2017

@DoctorBob if you are willing to add a non-standard lib, then check out https://loading.io/spinner/ - It would enable you to add a animated svg Icon.

@dokterbob
Copy link
Copy Markdown
Collaborator

@dkdndes Sounds like overkill to me.

Couldn't we just use one of their spinners and copy it as a direct replacement?

@dokterbob
Copy link
Copy Markdown
Collaborator

I guess the simplest option would be to add a static SVG spinner image and then use stepped CSS animation to animate it.

@newearthmartin newearthmartin force-pushed the master branch 7 times, most recently from 716b4d8 to e48481c Compare September 7, 2025 06:04
@newearthmartin newearthmartin force-pushed the master branch 2 times, most recently from 87e32e0 to 7071815 Compare December 18, 2025 01:36
@claudep claudep closed this by deleting the head repository Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create and integrate custom SVG icons

4 participants