fix: add missing return in loadWorktrees and bounds check in status parser#5369
Open
mango766 wants to merge 1 commit intojesseduffield:masterfrom
Open
fix: add missing return in loadWorktrees and bounds check in status parser#5369mango766 wants to merge 1 commit intojesseduffield:masterfrom
mango766 wants to merge 1 commit intojesseduffield:masterfrom
Conversation
…arser 1. refresh_helper.go: Added missing `return` in loadWorktrees error path. Without it, the empty-slice fallback was immediately overwritten by the nil worktrees value from the failed GetWorktrees() call. 2. file_loader.go: Added bounds check before accessing splitLines[i+1] in the rename/copy status parser to prevent index out-of-bounds panic on truncated git output. Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small defensive fixes:
refresh_helper.go: Added missing
returninloadWorktreeserror path. Without it, the empty-slice fallback was immediately overwritten by the nil worktrees value.file_loader.go: Added bounds check before accessing
splitLines[i+1]in the rename/copy status parser to prevent panic on truncated git output.Closes #5368