Ensure useDebounceCallback flushes on dep change or unmount#686
Open
Aleuck wants to merge 3 commits intojuliencrn:masterfrom
Open
Ensure useDebounceCallback flushes on dep change or unmount#686Aleuck wants to merge 3 commits intojuliencrn:masterfrom
useDebounceCallback flushes on dep change or unmount#686Aleuck wants to merge 3 commits intojuliencrn:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 38525bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
useDebounceCallback flushes on dep change or unmount;useDebounceCallback flushes on dep change or unmount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is an important improvement to make sure pending debounced invocations are called right before unmounting or dependency changes to the hook.
Someone might want them to be cancelled in these cases instead, but I think the general expectation is that if you make a call to a debounced function, it will eventually be invoked.
If the needs arise, we could add a new boolean option or a union type: