wait for Kube resource instead of APIBinding to make e2e tests more reliable#154
Open
xrstf wants to merge 1 commit intokcp-dev:mainfrom
Open
wait for Kube resource instead of APIBinding to make e2e tests more reliable#154xrstf wants to merge 1 commit intokcp-dev:mainfrom
xrstf wants to merge 1 commit intokcp-dev:mainfrom
Conversation
kcp-ci-bot
added
kind/flake
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/M
…eliable On-behalf-of: @SAP christoph.mewes@sap.com
kcp-ci-bot
added
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is an everso small delay between an API being marked as Bound, and it truly being usable. This small delay is causing quite a few e2e flakes in our CI environment.
This PR uses a more brute-force, but reliable way to probing for a resource.
What Type of PR Is This?
/kind flake
Release Notes