Skip to content

Run hack/update-codegen.sh on Dependabot PRs #8805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Jan 14, 2026
Merged

Run hack/update-codegen.sh on Dependabot PRs #8805

knative-prow merged 1 commit into from
Jan 14, 2026

Conversation

@creydr
Copy link
Member

@creydr creydr commented Nov 25, 2025

Currently we don't run hack/update-codegen.sh on Dependabot PRs like #8801. This leads to failing "verify codegen" jobs.

This PR addresses it and runs hack/update-codegen.sh on dependabot PRs

@creydr creydr requested review from Cali0707 and twoGiants November 25, 2025 12:07
@knative-prow knative-prow bot requested review from aliok and pierDipi November 25, 2025 12:07
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.15%. Comparing base (6ae393a) to head (1f34bb9).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8805   +/-   ##
=======================================
  Coverage   51.14%   51.15%           
=======================================
  Files         409      409           
  Lines       21360    21360           
=======================================
+ Hits        10924    10926    +2     
+ Misses       9584     9583    -1     
+ Partials      852      851    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr
Copy link
Member Author

creydr commented Dec 3, 2025

/test reconciler-tests
/cc @Cali0707 @twoGiants @matzew

@knative-prow knative-prow bot requested a review from matzew December 3, 2025 08:28
@creydr
Copy link
Member Author

creydr commented Jan 12, 2026

/test reconciler-tests

Cali0707
Cali0707 reviewed Jan 12, 2026
View reviewed changes
.github/workflows/update-dependabot-pr.yaml
run: |
if ! git diff --exit-code --quiet
then
git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
Copy link
Member

@Cali0707 Cali0707 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creydr where is this user.email constant coming from?

Copy link
Member Author

@creydr creydr Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly from the EKB workflow :D https://github.com/knative-extensions/eventing-kafka-broker/blob/705052aca1c0dddab3d71f0f36cb6fa620216a26/.github/workflows/update-dependabot-pr.yaml#L40

But there is also a GH community discussion, which mentions this: https://github.com/orgs/community/discussions/26560

Copy link
Member

@Cali0707 Cali0707 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Cali0707
Cali0707 approved these changes Jan 12, 2026
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @creydr !

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@Cali0707
Copy link
Member

Cali0707 commented Jan 12, 2026

/retest-required

@knative-prow
Copy link

knative-prow bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Jan 14, 2026

/retest-required

@knative-prow knative-prow bot merged commit 59b517c into knative:main Jan 14, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@twoGiants twoGiants Awaiting requested review from twoGiants

@aliok aliok Awaiting requested review from aliok

@pierDipi pierDipi Awaiting requested review from pierDipi

@matzew matzew Awaiting requested review from matzew

Assignees

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@creydr @Cali0707