fix: make Quarkus default builder image multi-arch#3838
Conversation
Fixes knative#3781 Changes the Quarkus default builder from ghcr.io/knative/builder-jammy-tiny:v2 (amd64-only) to paketobuildpacks/builder-ubi8-base (multi-arch) to support s390x and ppc64le clusters. Problem: - Quarkus builds failed on non-amd64 clusters (s390x/ppc64le) - DefaultBuilderImages["quarkus"] was hardcoded to DefaultTinyBuilder - DefaultTinyBuilder (builder-jammy-tiny:v2) only supports amd64 - Non-amd64 clusters got silent 'exec format error' Solution: - Created DefaultQuarkusBuilder = "paketobuildpacks/builder-ubi8-base" - Changed DefaultBuilderImages["quarkus"] to use DefaultQuarkusBuilder - paketobuildpacks/builder-ubi8-base supports amd64, s390x, ppc64le, arm64 Testing: - Added TestBuild_QuarkusBuilderMultiArch to verify the change - Test ensures Quarkus uses multi-arch builder, not amd64-only - All existing buildpacks tests pass The paketobuildpacks/builder-ubi8-base image is already in the trusted builder image prefixes list (docker.io/paketobuildpacks/), so no security changes are needed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Itx-Psycho0 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
size/M
|
Hi @Itx-Psycho0. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @lkingland, I've completed the fix for Issue #3781 (Quarkus multi-arch builder). Here's what I did: Problem: Solution: Changes:
Branch: fix/3781-quarkus-multi-arch Hardware Access: The code changes are complete and tested - just need hardware validation for full confidence. Ready for review when you have time! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3838 +/- ##
==========================================
- Coverage 53.44% 53.33% -0.12%
==========================================
Files 200 200
Lines 23450 23450
==========================================
- Hits 12534 12507 -27
- Misses 9662 9691 +29
+ Partials 1254 1252 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Itx-Psycho0 tests are failing. |
Actually our builders are multi-arch, but just for amd64 and arm64. |
|
Is |
Also we do not want to depend on docker hub. |
ReviewThe PR proposes switching the Quarkus default builder from
This PR would regress arm64 Quarkus builds while fixing nothing — neither image supports s390x or ppc64le, which is the actual problem described in #3781. Additional issues
RecommendationDo not merge. To actually fix #3781, someone would need to either build and publish multi-arch variants of the Knative builder images that include s390x/ppc64le, or take a different approach entirely. |
2 participants
What This PR Does
This PR fixes Quarkus function builds on non-amd64 architectures (s390x, ppc64le, arm64) by switching to a multi-arch builder image.
Background
Issue #3781 reported that Quarkus builds were failing on s390x and ppc64le clusters with silent
exec format error. The root cause was that the default Quarkus builder image (ghcr.io/knative/builder-jammy-tiny:v2) only supports amd64 architecture.When a user tried to build a Quarkus function on a non-amd64 cluster, the build would fail because the builder image couldn't run on that architecture. The error was silent and confusing for users.
What I Changed
I swapped the Quarkus default builder from the amd64-only image to a multi-arch image that supports all major architectures:
Before:
After:
The new
paketobuildpacks/builder-ubi8-baseimage supports:Implementation Details
File:
pkg/buildpacks/builder.goDefaultQuarkusBuilder = "paketobuildpacks/builder-ubi8-base"DefaultBuilderImages["quarkus"]to use this new builder instead ofDefaultTinyBuilderFile:
pkg/buildpacks/builder_test.goTestBuild_QuarkusBuilderMultiArchtest to verify Quarkus uses the multi-arch builderSecurity
The
paketobuildpacks/builder-ubi8-baseimage is already in the trusted builder image prefixes list (docker.io/paketobuildpacks/), so no additional security configuration is needed.Testing
I've added a unit test that verifies the correct builder is selected for Quarkus functions. All existing buildpacks tests continue to pass.
Test Results:
Hardware Access Note
I don't currently have access to s390x or ppc64le hardware for end-to-end testing. The unit tests verify that the correct multi-arch builder is selected. If someone with access to these architectures can test the actual build process, that would be great for validation.
Test command:
func create -l quarkus test-quarkus cd test-quarkus func build func deployWhat This Fixes
exec format errormessages anymoreFixes #3781