Skip to content

Fix matchSubdomain function to correctly handle exact domain matches#2802

Open
suwakei wants to merge 2 commits into
labstack:masterfrom
suwakei:fix/util.go
Open

Fix matchSubdomain function to correctly handle exact domain matches#2802
suwakei wants to merge 2 commits into
labstack:masterfrom
suwakei:fix/util.go

Conversation

@suwakei

@suwakei suwakei commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Problem

The matchSubdomain function incorrectly returns false for exact domain matches without wildcards—for example, http://example.com vs. http://example.com.

Cause

Even if all parts match during iteration, the function still returns false at the end.

Fix

After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return true—i.e., treat it as an exact match.

This PR adds that check.

@suwakei

suwakei commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Hi! Just following up to see if there's anything I can improve in this PR 🙇

@FrancoTampieri

Copy link
Copy Markdown

My two cents:
I think the only think is missed the specific test for that case in util_test.go

@suwakei

suwakei commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

I added specific unit test

@suwakei

suwakei commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

Hi maintainers 👋
Just following up on this PR — happy to make any changes if needed. Please let me know if there's anything blocking review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants