chore(deps): relax packaging constraint to allow v26#1569
Closed
noirbee wants to merge 2 commits intolangfuse:mainfrom
Closed
chore(deps): relax packaging constraint to allow v26#1569noirbee wants to merge 2 commits intolangfuse:mainfrom
noirbee wants to merge 2 commits intolangfuse:mainfrom
Conversation
It is only used for packaging.version.Version, which saw no breaking changes in version 26.
|
|
Contributor
|
Thanks for raising this, will be handled in #1570 👍🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is only used for packaging.version.Version, which saw no breaking changes in version 26.
I'm not sure about the
content-hashchange inpoetry.locksince there are no changes to the lockfile itself; I guess it also takes into account the inputpyproject.tomlitself ?Disclaimer: Experimental PR review
Greptile Summary
This PR relaxes the
packagingdependency constraint inpyproject.tomlfrom>=23.2,<26.0to>=23.2,<27, unblocking users and downstream consumers who needpackagingv26. Thecontent-hashupdate inpoetry.lockis expected — Poetry regenerates this hash frompyproject.toml's contents on every change.Key observations:
packagingin this codebase arefrom packaging.version import Versioninlangfuse/openai.pyandlangfuse/_client/client.py— both at module top level, not inside functions.packagingv26.0 changelog (released 2026-01-20) confirms no breaking changes topackaging.version.Version— the API is additive only (e.g. new__replace__support, positional pattern matching), so existing call sites remain fully compatible.<27is a reasonable conservative bound that prevents untested future major versions from being auto-accepted.Confidence Score: 5/5
packagingv26.0 release has no breaking changes topackaging.version.Version, the sole API consumed by this library. Thepoetry.lockchange is mechanically expected. No logic, tests, or behavior is altered.Important Files Changed
packagingdependency upper bound from<26.0to<27, allowing v26.x. Thepackaginglibrary's v26.0 changelog confirms no breaking changes topackaging.version.Version, which is the only API used in this codebase.content-hashwas updated, which is expected — Poetry recomputes this hash from the contents ofpyproject.tomlwhenever it changes, even if the resolved lockfile itself is unmodified.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["packaging constraint: >=23.2,<26.0"] -->|"PR change"| B["packaging constraint: >=23.2,<27"] B --> C{Allowed versions} C --> D["23.2 – 25.x ✅ (unchanged)"] C --> E["26.x ✅ (newly allowed)"] C --> F["27+ ❌ (still excluded)"] E --> G["packaging.version.Version API\nNo breaking changes in v26"] G --> H["langfuse/openai.py\n(from packaging.version import Version)"] G --> I["langfuse/_client/client.py\n(from packaging.version import Version)"]Last reviewed commit: "chore(deps): relax p..."
(2/5) Greptile learns from your feedback when you react with thumbs up/down!