fix: handle FDv2 intentCode none as listening, reject unknown codes#555
Open
beekld wants to merge 26 commits into
Open
fix: handle FDv2 intentCode none as listening, reject unknown codes#555beekld wants to merge 26 commits into
beekld wants to merge 26 commits into
Conversation
beekld
added a commit
that referenced
this pull request
Jun 12, 2026
beekld
added a commit
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the FDv2 protocol handler's
server-intentdispatch in line with the spec and the Java implementation.intentCode: nonekeeps the handler in listening state so a subsequent partial cycle works.none.Note
Medium Risk
Changes streaming protocol state machine behavior for
server-intent, which can affect how clients process FDv2 payloads; scope is limited to intent dispatch with new tests.Overview
Aligns
server-intenthandling inFDv2ProtocolHandlerwith the FDv2 spec and Java client.For
intentCode: none, the handler still emits an immediate emptykNonechangeset, but it now leaves internal state in partial/listening mode instead of inactive, so a laterput-object/payload-transferredcycle can produce a partial changeset.Unrecognized intent codes (deserialized as
kUnknown) are no longer treated likenone: the handler resets and returns aProtocolErrorwith "server-intent had an unrecognized intent code".Tests cover a partial cycle after
noneand protocol errors for unknown codes (e.g.future-code).Reviewed by Cursor Bugbot for commit f40b13f. Bugbot is set up for automated code reviews on this repo. Configure here.