Skip to content

fix: handle FDv2 intentCode none as listening, reject unknown codes#555

Open
beekld wants to merge 26 commits into
mainfrom
beeklimt/SDK-2515
Open

fix: handle FDv2 intentCode none as listening, reject unknown codes#555
beekld wants to merge 26 commits into
mainfrom
beeklimt/SDK-2515

Conversation

@beekld

@beekld beekld commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Bring the FDv2 protocol handler's server-intent dispatch in line with the spec and the Java implementation.

  • intentCode: none keeps the handler in listening state so a subsequent partial cycle works.
  • Unrecognised intent codes return a protocol error instead of being collapsed with none.

Note

Medium Risk
Changes streaming protocol state machine behavior for server-intent, which can affect how clients process FDv2 payloads; scope is limited to intent dispatch with new tests.

Overview
Aligns server-intent handling in FDv2ProtocolHandler with the FDv2 spec and Java client.

For intentCode: none, the handler still emits an immediate empty kNone changeset, but it now leaves internal state in partial/listening mode instead of inactive, so a later put-object / payload-transferred cycle can produce a partial changeset.

Unrecognized intent codes (deserialized as kUnknown) are no longer treated like none: the handler resets and returns a ProtocolError with "server-intent had an unrecognized intent code".

Tests cover a partial cycle after none and protocol errors for unknown codes (e.g. future-code).

Reviewed by Cursor Bugbot for commit f40b13f. Bugbot is set up for automated code reviews on this repo. Configure here.

beekld added 25 commits June 5, 2026 11:02
beekld added a commit that referenced this pull request Jun 12, 2026
Base automatically changed from beeklimt/SDK-2379-4 to main June 15, 2026 23:23
beekld added a commit that referenced this pull request Jun 15, 2026
@beekld beekld marked this pull request as ready for review June 15, 2026 23:57
@beekld beekld requested a review from a team as a code owner June 15, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant