expand default permissions table to use full page width#1083
Conversation
Signed-off-by: areychana <93970069+areychana@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request wraps the permissions tabpane in a new <div class="permissions-tabpane"> container and adds corresponding SCSS styles to format the permissions tables. The reviewer suggests refactoring the newly added SCSS rules to leverage nesting, which improves readability and maintainability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: areychana <93970069+areychana@users.noreply.github.com>
|
Preview deployment for PR #1083 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
KatalKavya96
left a comment
There was a problem hiding this comment.
Thanks for working on this @areychana,
I reviewed the PR and compared it with the reported issue.
The changes look good to me:
- The permissions tab pane is now wrapped separately so it is no longer affected by the previous list/max-width constraint
- The table now uses the page width much better
- The role indicator columns in the Categories tab are visually cleaner after being centred
- The Roles tab also looks improved with the fixed table layout and better Description column width
- The follow up SCSS nesting refactor also makes the styling cleaner and easier to maintain
I checked the preview behaviour and the table now makes much better use of the available horizontal space while keeping the content readable
Looks good to me!
Notes for Reviewers
This PR fixes #1082
The default permissions table box was constrained to ~80% of the content column width due to the tabpane shortcode rendering inside a
<ul>element, which hadmax-width: 80%applied by the theme.Changes i made:
<div class="permissions-tabpane">to render it outside theulconstrainttable-layout: fixedwith a 25/75 splitSigned commits