[Sistent] Add FormControl component documentation to Sistent components page#7445
[Sistent] Add FormControl component documentation to Sistent components page#7445shteypandey28-hue wants to merge 7 commits intolayer5io:masterfrom
Conversation
Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
d199951 to
e4b1f7c
Compare
|
I have made the form control component, kindly review it and merge. |
|
🚀 Preview for commit e4b1f7c at: https://69a597b89f9e154a4fa40b3f--layer5.netlify.app |
|
🚀 Preview for commit 89643c4 at: https://69a5c58659ef5364910479a8--layer5.netlify.app |
| Radio, | ||
| } from "@sistent/sistent"; | ||
| import { | ||
| FormControl, |
There was a problem hiding this comment.
Please use the Sistent FormControl component, example -> import { FormControl } from "@sistent/sistent";.
There was a problem hiding this comment.
changes have been made
|
🚀 Preview for commit 7ef1216 at: https://69a5d2ee2b301d9f37ab5804--layer5.netlify.app |
|
@Rajesh-Nagarajan-11 both the changes have been made , kindly go through it and tell if any further assistant is needed. |
c6b6e50 to
d74cd36
Compare
|
🚀 Preview for commit d74cd36 at: https://69a64dd2e3ffef73b38a39bf--layer5.netlify.app |
|
@shteypandey28-hue Please revert the lint changes and when committing use --no-verify. Furthermore, the dropdown isn’t working for the overview and guidance section in your current commit. Screen.Recording.2026-03-03.at.8.30.21.AM.mov |
matrixkavi
left a comment
There was a problem hiding this comment.
Please ensure that you are changing only the lines you intend to change. A lot of changes are there in this PR as well as the previous PR 7444 where you have added formatting related changes to js files. It can be cumbersome to review and can result in unwanted changes creeping in unknowingly.
rishiraj38
left a comment
There was a problem hiding this comment.
Please revert the lint changes and when committing use --no-verify. Furthermore, the dropdown isn’t working for the overview and guidance section in your current commit.
|
🚀 Preview for commit d77413b at: https://69a6b9cc450c3964e2be8e4b--layer5.netlify.app |
Add complete FormControl documentation with Overview, Guidance, and Code tabs. Includes examples for Select, Checkbox, and Radio controls with proper state management using controlled components. Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
d77413b to
fdceeaa
Compare
|
🚀 Preview for commit fdceeaa at: https://69a6dea1e3ffef8f648a3cfe--layer5.netlify.app |
|
Made the changes , please review it and tell me if any further assistant is need .. if not merge it . |
Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
|
🚀 Preview for commit bc109f0 at: https://69a6f0a5ee811432e437f6a2--layer5.netlify.app |
|
🚀 Preview for commit 1cfe82c at: https://69a73836a1f8cfb76337a94c--layer5.netlify.app |
…-node.js Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
1cfe82c to
0674a67
Compare
|
🚀 Preview for commit 0674a67 at: https://69a73ddb7e83ec7b8b40820b--layer5.netlify.app |
There was a problem hiding this comment.
@shteypandey28-hue Could you explain the changes made here?
There was a problem hiding this comment.
T he maintainer already flagged them — In an earlier cleanup commit (Fix: remove unrelated news files from FormControl PR), those files were explicitly removed because they don't belong.
They're completely unrelated — docker-kanvas-infoq.webp and index.mdx are a news article about
There was a problem hiding this comment.
@saurabhraghuvanshii Could you please take a look? I don’t think we need to remove that recent news article we added.
There was a problem hiding this comment.
@shteypandey28-hue please revert this, and open Pr only releted to issue. No need to remove new articles and anything. Your work in this is only to add new sistent components.
gatsby-node.js
Outdated
| createPage({ | ||
| path: pagePath, | ||
| component: require.resolve(componentPath), | ||
| component: path.resolve(componentPath), |
| }, | ||
|
|
||
| { | ||
| id: 121, |
There was a problem hiding this comment.
The navigation for FormControl should be placed above the FormControlLabel.
- Revert gatsby-node.js to use require.resolve (matching upstream) - Revert unintended lint reformatting in SistentNavigation/content.js - Revert unintended lint reformatting in components/content.js - Re-add FormControl navigation entries (IDs 121-123) in original style - Re-add FormControl components data entry (ID 37) in original style Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
|
🚀 Preview for commit f06b149 at: https://69aad8117dc51e72c0166ff8--layer5.netlify.app |
|
@shteypandey28-hue Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |



Description
This PR adds documentation for the FormControl component to the Sistent components section.
The following has been implemented:
This ensures FormControl is properly documented similar to other Sistent components.
Closes #5935
Notes for Reviewers
npm run develop.