Skip to content

[Sistent] Add FormControl component documentation to Sistent components page#7445

Open
shteypandey28-hue wants to merge 7 commits intolayer5io:masterfrom
shteypandey28-hue:sistent-formcontrol-docs
Open

[Sistent] Add FormControl component documentation to Sistent components page#7445
shteypandey28-hue wants to merge 7 commits intolayer5io:masterfrom
shteypandey28-hue:sistent-formcontrol-docs

Conversation

@shteypandey28-hue
Copy link

Description

This PR adds documentation for the FormControl component to the Sistent components section.

The following has been implemented:

  • Overview page
  • Guidance page
  • Code examples page
  • Navigation entry in Sistent sidebar
  • Component registration in components listing
  • Gatsby route wrappers for proper routing

This ensures FormControl is properly documented similar to other Sistent components.

Closes #5935


Notes for Reviewers

  • Documentation follows the same structure as Stack and FormGroup components.
  • Tested locally using npm run develop.
  • All commits are signed.

Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
@shteypandey28-hue shteypandey28-hue force-pushed the sistent-formcontrol-docs branch from d199951 to e4b1f7c Compare March 2, 2026 13:44
@shteypandey28-hue
Copy link
Author

I have made the form control component, kindly review it and merge.

@l5io
Copy link
Member

l5io commented Mar 2, 2026

🚀 Preview for commit e4b1f7c at: https://69a597b89f9e154a4fa40b3f--layer5.netlify.app

@l5io
Copy link
Member

l5io commented Mar 2, 2026

🚀 Preview for commit 89643c4 at: https://69a5c58659ef5364910479a8--layer5.netlify.app

Radio,
} from "@sistent/sistent";
import {
FormControl,
Copy link
Member

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the Sistent FormControl component, example -> import { FormControl } from "@sistent/sistent";.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes have been made

@Rajesh-Nagarajan-11
Copy link
Member

image Placeholder not works well

@l5io
Copy link
Member

l5io commented Mar 2, 2026

🚀 Preview for commit 7ef1216 at: https://69a5d2ee2b301d9f37ab5804--layer5.netlify.app

@shteypandey28-hue
Copy link
Author

@Rajesh-Nagarajan-11 both the changes have been made , kindly go through it and tell if any further assistant is needed.

Copy link
Contributor

@YASHMAHAKAL YASHMAHAKAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image Image

@shteypandey28-hue Still no improvements :(

@shteypandey28-hue shteypandey28-hue force-pushed the sistent-formcontrol-docs branch from c6b6e50 to d74cd36 Compare March 3, 2026 02:40
@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit d74cd36 at: https://69a64dd2e3ffef73b38a39bf--layer5.netlify.app

@rishiraj38
Copy link
Contributor

rishiraj38 commented Mar 3, 2026

@shteypandey28-hue Please revert the lint changes and when committing use --no-verify. Furthermore, the dropdown isn’t working for the overview and guidance section in your current commit.

Screen.Recording.2026-03-03.at.8.30.21.AM.mov

Copy link
Member

@matrixkavi matrixkavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that you are changing only the lines you intend to change. A lot of changes are there in this PR as well as the previous PR 7444 where you have added formatting related changes to js files. It can be cumbersome to review and can result in unwanted changes creeping in unknowingly.

Copy link
Contributor

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the lint changes and when committing use --no-verify. Furthermore, the dropdown isn’t working for the overview and guidance section in your current commit.

@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit d77413b at: https://69a6b9cc450c3964e2be8e4b--layer5.netlify.app

Add complete FormControl documentation with Overview, Guidance,
and Code tabs. Includes examples for Select, Checkbox, and Radio
controls with proper state management using controlled components.

Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
@shteypandey28-hue shteypandey28-hue force-pushed the sistent-formcontrol-docs branch from d77413b to fdceeaa Compare March 3, 2026 12:57
@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit fdceeaa at: https://69a6dea1e3ffef8f648a3cfe--layer5.netlify.app

@shteypandey28-hue
Copy link
Author

Made the changes , please review it and tell me if any further assistant is need .. if not merge it .

Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
@github-actions github-actions bot added the area/news A noteworthy article, event, happening label Mar 3, 2026
@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit bc109f0 at: https://69a6f0a5ee811432e437f6a2--layer5.netlify.app

@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit 1cfe82c at: https://69a73836a1f8cfb76337a94c--layer5.netlify.app

…-node.js

Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
@shteypandey28-hue shteypandey28-hue force-pushed the sistent-formcontrol-docs branch from 1cfe82c to 0674a67 Compare March 3, 2026 19:44
@l5io
Copy link
Member

l5io commented Mar 3, 2026

🚀 Preview for commit 0674a67 at: https://69a73ddb7e83ec7b8b40820b--layer5.netlify.app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shteypandey28-hue Could you explain the changes made here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T he maintainer already flagged them — In an earlier cleanup commit (Fix: remove unrelated news files from FormControl PR), those files were explicitly removed because they don't belong.
They're completely unrelated — docker-kanvas-infoq.webp and index.mdx are a news article about

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii Could you please take a look? I don’t think we need to remove that recent news article we added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shteypandey28-hue please revert this, and open Pr only releted to issue. No need to remove new articles and anything. Your work in this is only to add new sistent components.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the lints

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the lints

gatsby-node.js Outdated
createPage({
path: pagePath,
component: require.resolve(componentPath),
component: path.resolve(componentPath),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change

},

{
id: 121,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navigation for FormControl should be placed above the FormControlLabel.

- Revert gatsby-node.js to use require.resolve (matching upstream)
- Revert unintended lint reformatting in SistentNavigation/content.js
- Revert unintended lint reformatting in components/content.js
- Re-add FormControl navigation entries (IDs 121-123) in original style
- Re-add FormControl components data entry (ID 37) in original style

Signed-off-by: shteypandey28-hue <shteypandey28@gmail.com>
@l5io
Copy link
Member

l5io commented Mar 6, 2026

🚀 Preview for commit f06b149 at: https://69aad8117dc51e72c0166ff8--layer5.netlify.app

@Bhumikagarggg
Copy link
Contributor

@shteypandey28-hue Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/news A noteworthy article, event, happening area/site-config project/sistent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sistent] Add FormControl component to the sistent components page

8 participants