fix: improve integration logo visibility in dark and light mode#7706
fix: improve integration logo visibility in dark and light mode#7706AnkitRewar11 wants to merge 4 commits into
Conversation
|
Preview deployment for PR #7706 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
AnkitRewar11
force-pushed
the
fix/dark-mode-integration-logos
branch
from
1d3022a to
719f704
Compare
|
@AnkitRewar11, could you please make a commit so the preview can be built? |
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
src/collections/integrations/rustrial-aws-eks-iam-auth-controller/icons/color/rustrial-aws-eks-iam-auth-controller-color.svg.
src/collections/integrations/rustrial-aws-eks-iam-auth-controller/icons/white/rustrial-aws-eks-iam-auth-controller-white.svg.
src/collections/integrations/solr-operator/icons/white/solr-operator-white.svg.
src/collections/integrations/vald/icons/white/vald-white.svg
Please fix these images they are showing some errors
|
@AnkitRewar11 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
AnkitRewar11
force-pushed
the
fix/dark-mode-integration-logos
branch
from
6456dfe to
b4242f7
Compare
- Fix darkModeIntegrationIcon reference in IntegrationsGrid.js - Fix Aerospike white SVG color from dark to white - Fix Solr SVG by removing invalid sodipodi tags - Fix Ngrok color SVG empty clipPath and update fill color - Fix Vald empty white SVG with proper white paths - Fix Rustrial AWS EKS empty SVG files with placeholder icons Signed-off-by: ankitrewar11 <ankitrewar11@gmail.com>
AnkitRewar11
force-pushed
the
fix/dark-mode-integration-logos
branch
from
b4242f7 to
8281237
Compare
|
Hi @rishiraj38, Thank you for the review! I have addressed all the reported issues. Regarding the integration page issue is only showing up in the preview. When I build it locally, everything works normally on my side. That’s why I feel something might be wrong with the preview environment, because locally I’m not able to reproduce the issue. And as you can see, I only added one class name for darkMode in the code everything else is unchanged. Please let me know if any further changes are needed. |
| const integrationIcon = item.frontmatter.integrationIcon.publicURL; | ||
| const darkModeIntegrationIcon = item.frontmatter.integrationIcon; | ||
| const darkModeIntegrationIcon = | ||
| item.frontmatter.darkModeIntegrationIcon; |
There was a problem hiding this comment.
Please keep this on the same line.
|
@saurabhraghuvanshii @Rajesh-Nagarajan-11 Please take a look at this PR. |
There was a problem hiding this comment.
@AnkitRewar11 I think this image is not working can you please check this.
KatalKavya96
left a comment
KatalKavya96
left a comment
There was a problem hiding this comment.
Hi @AnkitRewar11, just checking in — are you still working on the requested changes for this PR?
There are a couple of pending review comments around the solr-operator-white.svg and vald-white.svg files not rendering correctly. Once those are addressed, this PR should be easier to move forward.
Thanks for your work on this!
|
@KatalKavya96 Hey, sorry for the delay. I'll get back to working on this and resume it as soon as possible. |
|
@AnkitRewar11 No problem at all, I was just checking whether you’re still working on it so the PR can keep moving forward. |
6 participants
Description
Fixes #7676
This PR fixes integration logo visibility issues in both dark mode and light mode on the Meshery integrations page.
Changes Made
darkModeIntegrationIconreference that was pointing to color icon instead of white icon#1A1A1A(dark) instead of#FFFFFF(white), causing invisibility in dark modesodipodi:namedviewtags from both color and white SVGs that were causing rendering issues in dark modeclipPathin color SVG that was hiding the logo in light mode, and updated fill color to#006AFFNotes for Reviewers
Signed commits