Have the mock log facade not always print to stdout#510
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Apr 15, 2025
Merged
Have the mock log facade not always print to stdout#510tnull merged 1 commit intolightningdevkit:mainfrom
stdout#510tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #463 we introduced a mock logger that implements the
logfacade in tests. Previously, it defaulted to always printTRACE-level logs tostdout. This however can be very spammy (especially since it includes TRACE-level logs ofelectrum_clientnow).Here, we make printing the log lines optional by
cfg-gating it.(cc @enigbe)