Skip to content

This PR addresses the out-of-memory (OOM) errors during the artifact upload stage in the CI pipeline.#4478

Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Atishyy27:fix-ci-oom-error
Mar 19, 2026
Merged

This PR addresses the out-of-memory (OOM) errors during the artifact upload stage in the CI pipeline.#4478
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Atishyy27:fix-ci-oom-error

Conversation

@Atishyy27
Copy link
Contributor

Key Changes:

  • Action Updates: Upgraded actions/upload-artifact, actions/download-artifact, and actions/checkout to @v4 to ensure Node 20 compatibility and improved performance.
  • Memory Optimization: Set compression-level: 0 for the hfuzz-corpus upload in build.yml. Disabling compression prevents the runner from exhausting memory while processing large fuzzing datasets.
  • SemVer Fix: Added fetch-depth: 0 to the SemVer check workflow to prevent tool panics during baseline comparisons.

Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 11, 2026

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (066859b) to head (43066b7).
⚠️ Report is 2759 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4478      +/-   ##
==========================================
+ Coverage   84.55%   86.20%   +1.64%     
==========================================
  Files         135      161      +26     
  Lines       76569   107332   +30763     
  Branches    76569   107332   +30763     
==========================================
+ Hits        64745    92525   +27780     
- Misses       9783    12192    +2409     
- Partials     2041     2615     +574     
Flag Coverage Δ
tests 86.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Atishyy27 Atishyy27 marked this pull request as ready for review March 12, 2026 16:31
@Atishyy27
Copy link
Contributor Author

Atishyy27 commented Mar 12, 2026

Hey @TheBlueMatt @carlaKC ,

All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m).

The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet.

Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated!

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.

run: cargo semver-checks
- name: Check SemVer without any non-default features
run: cargo semver-checks --only-explicit-features
run: cargo semver-checks --only-explicit-features No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont drop the EOL newline?

- name: Checkout source code
uses: actions/checkout@v4
with:
fetch-depth: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo-semver-checks needs to compare your current code against the "baseline" (the last release). By default, GitHub Actions does a "shallow clone" (only the last commit). Without the full history, the tool cannot find the previous version and crashes (it was giving Exit Code 101).

@Atishyy27
Copy link
Contributor Author

Hey @TheBlueMatt @carlaKC,

Thanks for the feedback! I just force-pushed an update with these changes:

  • Rebase: Rebased the branch to drop the merge commit, so it's just one clean commit on top of main now.
  • v6 Updates: I went ahead and updated the action versions to v6 in all the other workflow files too, since Carla suggested bumping them everywhere.
  • Formatting: Fixed the missing newline at the end of semver.yml and removed that duplicate line.
  • fetch-depth: Regarding fetch-depth: 0—cargo-semver-checks was panicking (Exit Code 101) because the default shallow clone doesn't pull the old release tags it needs for the baseline comparison. Fetching the full history fixed the crash.

Let me know if this looks good to go

@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @joostjager! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@Atishyy27 Atishyy27 requested a review from TheBlueMatt March 15, 2026 17:52
- name: Cache routing graph snapshot
id: cache-graph
uses: actions/cache@v4
uses: actions/cache@v6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is complaining because this doesn't exist.

@joostjager joostjager removed their request for review March 16, 2026 08:10
@joostjager joostjager force-pushed the fix-ci-oom-error branch 2 times, most recently from 09275e3 to b4fee40 Compare March 19, 2026 11:17
run: cargo semver-checks
- name: Check SemVer without any non-default features
run: cargo semver-checks --only-explicit-features

No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes the trailing newline from the file (note the \ No newline at end of file marker in the diff). POSIX convention and most linters expect files to end with a newline. Please add the newline back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@ldk-claude-review-bot
Copy link
Collaborator

@joostjager
Copy link
Contributor

@Atishyy27 reverted the v4->v6 change because it isn't compatible with the self-hosted runners. Given the urgency of fixing the fuzzer, I pushed the change.

@joostjager joostjager requested a review from TheBlueMatt March 19, 2026 12:40
@TheBlueMatt TheBlueMatt merged commit 7d82e14 into lightningdevkit:main Mar 19, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants