Drop ChannelManager-built-in BIP 353 resolution logic#4539
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Apr 3, 2026
Merged
Drop ChannelManager-built-in BIP 353 resolution logic#4539tnull merged 1 commit intolightningdevkit:mainfrom
ChannelManager-built-in BIP 353 resolution logic#4539tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @wpaulino as a reviewer! |
5 tasks
TheBlueMatt
force-pushed
the
2026-04-drop-native-dns
branch
from
4b84a25 to
77382df
Compare
Since we shipped the `bitcoin-payment-instructions` crate we generally expect downstream code to use that rather than doing BIP 353 DNS resolutions over onion messages directly from the `ChannelManager`. Thus, in 0.2 we marked `pay_for_offer_from_human_readable_name` deprecated and here remove it in favor of explicit references to the `bitcoin-payment-instructions` crate in documentation.
TheBlueMatt
force-pushed
the
2026-04-drop-native-dns
branch
from
77382df to
884158d
Compare
Collaborator
|
The remaining test ( No issues found. The PR is a straightforward removal of deprecated |
tnull
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we shipped the
bitcoin-payment-instructionscrate we generally expect downstream code to use that rather than doing BIP 353 DNS resolutions over onion messages directly from theChannelManager. Thus, in 0.2 we markedpay_for_offer_from_human_readable_namedeprecated and here remove it in favor of explicit references to thebitcoin-payment-instructionscrate in documentation.