Add fees value for recent payment details#4674
Open
randomlogin wants to merge 1 commit into
Open
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
Collaborator
|
I re-examined the full data flow and all construction/match sites:
No issues found. |
wpaulino
reviewed
Jun 10, 2026
| bool, | ||
| ) -> (Option<MonitorUpdateCompletionAction>, Option<RAAMonitorUpdateBlockingAction>), | ||
| ) | ||
| -> (Option<MonitorUpdateCompletionAction>, Option<RAAMonitorUpdateBlockingAction>), |
Contributor
There was a problem hiding this comment.
These should go away if you format with 1.75
| /// Total routing fees paid for this payment, as also reported via the `fee_paid_msat` | ||
| /// field of [`Event::PaymentSent`]. | ||
| /// | ||
| /// `None` for payments fulfilled before this field was introduced. |
Contributor
There was a problem hiding this comment.
We should note the specific version
Contributor
Author
There was a problem hiding this comment.
added specific version (0.3.0)
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Introduce fields `pending_fee_msat` for `RecentPaymentDetails::Pending` and `fee_paid_msat` for `RecentPaymentDetails::Fulfilled`.
randomlogin
force-pushed
the
expose-fees-in-payment-details
branch
from
95ece4a to
af19ed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to obtain fees of pending/fulfilled payments.
Also we can add and populate the fee field for
RecentPaymentDetails::Abandoned, but I doubt that it is useful, as the payment was not made.I ran cargo fmt, so unrelated parts of code were changed.
Removed unnecessary clarification "in msat" for
total_msatfield.