LCORE-1720: LCORE package release#1738
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR adds a comprehensive release procedure guide to the project documentation and links it throughout the README and documentation structure. The new ChangesRelease documentation and integration
🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/releasing.md`:
- Line 145: Update the tag example to match the release name RC index: change
the tag `0.6.0rc` to `0.6.0rc1` so the tag example and the release name
"Lightspeed Stack version 0.6.0rc1" are consistent.
- Line 52: Replace the incorrect TestPyPI URL string 'https://test.pypi.org/p'
in the docs/releasing.md prerequisites with the correct TestPyPI URL
'https://test.pypi.org/' so the access token instruction points to the valid
TestPyPI site.
- Around line 103-105: The markdown fenced code blocks in the docs (the blocks
containing the text "Successfully built lightspeed_stack-{version}.tar.gz and
lightspeed_stack-{version}-py3-none-any.whl", the block with the PyPI/ TestPyPI
credentials starting with "[testpypi]" and "[pypi]", and the block containing
the badge markdown
"[](https://github.com/lightspeed-core/lightspeed-stack/releases/tag/0.5.0)")
are missing language identifiers and trigger MD040; update each fenced block to
include an appropriate language identifier (e.g., ```text for the build output
line, ```ini for the PyPI config block, and ```markdown for the badge line) so
markdownlint passes.
- Line 66: The docs reference contains a typo in the integration test path:
change "tests/integration/endponts/test_rlsapi_v1_integration.py" to the correct
"tests/integration/endpoints/test_rlsapi_v1_integration.py" in docs/releasing.md
so links and readers point to the actual integration test file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 48bedafa-6c31-45f4-a4dc-f3be6eafe662
📒 Files selected for processing (4)
README.mddocs/README.mddocs/index.mddocs/releasing.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: integration_tests (3.13)
- GitHub Check: unit_tests (3.13)
- GitHub Check: unit_tests (3.12)
- GitHub Check: Pylinter
- GitHub Check: build-pr
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 3
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: library mode / ci / group 3
- GitHub Check: E2E Tests for Lightspeed Evaluation job
🧰 Additional context used
🪛 LanguageTool
docs/releasing.md
[style] ~39-~39: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ty in a backwards-compatible manner. * Increment PATCH when you make backwards-compatibl...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~76-~76: Consider a more concise word here.
Context: ... that is stored in docs/openapi.json. In order to do it, run the following command: ```b...
(IN_ORDER_TO_PREMIUM)
[style] ~76-~76: Consider a more expressive alternative.
Context: ...red in docs/openapi.json. In order to do it, run the following command: ```bash...
(DO_ACHIEVE)
[grammar] ~93-~93: Ensure spelling is correct
Context: ...s are deleted (the latest are hidden on Unit systems!) ### Build the distribution a...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~107-~107: Use a hyphen to join words.
Context: ...ion}-py3-none-any.whl ``` Please double check that the {version} really contai...
(QB_NEW_EN_HYPHEN)
[style] ~108-~108: Consider using a different verb to strengthen your wording.
Context: ...the correct version number. Also please make sure that the archive was really built to av...
(MAKE_SURE_ENSURE)
[grammar] ~151-~151: Ensure spelling is correct
Context: ... ### Update link in README.md At the beggining of README.md there's a line: ``` [![...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.22.1)
docs/releasing.md
[warning] 103-103: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 122-122: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 153-153: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (3)
README.md (1)
85-85: LGTM!Also applies to: 1225-1227
docs/README.md (1)
78-80: LGTM!docs/index.md (1)
85-87: LGTM!
| ## Prerequisites | ||
|
|
||
| * Access to https://github.com/lightspeed-core/lightspeed-stack as owner or maintainer | ||
| * Access token to https://pypi.org/ and/or to https://test.pypi.org/p |
There was a problem hiding this comment.
Fix broken TestPyPI URL in prerequisites.
Line 52 uses https://test.pypi.org/p, which is not a valid destination and can mislead maintainers during release prep. Use the proper TestPyPI URL.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/releasing.md` at line 52, Replace the incorrect TestPyPI URL string
'https://test.pypi.org/p' in the docs/releasing.md prerequisites with the
correct TestPyPI URL 'https://test.pypi.org/' so the access token instruction
points to the valid TestPyPI site.
tisnik
force-pushed
the
lcore-1720-lcore-package-release
branch
from
a06ff62 to
e956c8a
Compare
1 participant
Description
LCORE-1720: LCORE package release
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit