LCORE-2168: more unit tests for configuration loading

[tisnik]

Description

LCORE-2168: more unit tests for configuration loading

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement
• Benchmarks improvement

Tools used to create PR

• Assisted-by: N/A
• Generated by: N/A

Related Tickets & Documents

• Related Issue #LCORE-2168

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for configuration parsing with additional test cases and clarifying documentation.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 00d249c6-2034-4cd1-b77c-e209a1a114e6

📥 Commits

Reviewing files that changed from the base of the PR and between c44c728 and 2cd0b5e.

📒 Files selected for processing (1)

• tests/unit/test_configuration.py

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request

🧰 Additional context used

📓 Path-based instructions (1)

tests/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

tests/**/*.py: Use pytest for all unit and integration tests; do not use unittest
Use pytest.mark.asyncio marker for async tests

Files:

• tests/unit/test_configuration.py

🔇 Additional comments (2)

tests/unit/test_configuration.py (2)

2800-3207: LGTM!

---

3215-3216: LGTM!

---

Walkthrough

This PR extends test data in negative configuration parsing tests by adding new invalid configuration examples to the wrong_configurations dataset and including clarifying comments in the test function's exception validation block. No logic or exception handling changes.

Changes

Test Data Expansion

Layer / File(s)	Summary
Expanded configuration test data and documentation tests/unit/test_configuration.py	The wrong_configurations test fixture adds two new fake configuration dictionaries ("Ruth Davidson" and "Thomas Werner"), and clarifying comments are inserted in the test_init_from_dict_fake_data function within the pytest.raises() block to document the exception validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding more unit tests for configuration loading, which aligns with the changeset that expands the configuration parsing test dataset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tisnik]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.