Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jan 15, 2026

update changelog to 2.0.79

Log: update changelog to 2.0.79

Summary by Sourcery

Chores:

  • Update Debian changelog entries for version 2.0.79.

update changelog to 2.0.79

Log: update changelog to 2.0.79
@mhduiy mhduiy requested a review from 18202781743 January 15, 2026 11:44
@github-actions
Copy link

TAG Bot

TAG: 2.0.79
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 15, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the Debian package changelog to version 2.0.79, updating release metadata only.

File-Level Changes

Change Details Files
Update Debian changelog metadata for release 2.0.79.
  • Increment the recorded package version to 2.0.79 in the changelog entry.
  • Adjust associated changelog text to reference version 2.0.79 for this release.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这段 debian/changelog 的 diff 内容是标准的 Debian 包变更日志格式,用于记录软件包的版本更新历史。经过审查,我主要发现了一个严重错误和一些格式规范上的建议。以下是详细的审查意见:

1. 严重错误:时间戳日期异常

  • 问题:在版本 2.0.79 的头部,维护者签名的时间戳显示为 Thu, 15 Jan 2026
  • 影响:年份显示为 2026年,这是一个未来的日期。
  • 建议:请立即检查系统时间或提交记录,将年份修正为当前年份(如 2024 或 2025)。错误的年份可能会导致构建工具(如 dpkg-buildpackage)发出警告,或者在发布时造成混淆。

2. 格式与规范审查

  • 格式正确性
    • 符合 Debian changelog 规范,格式标准。
    • 使用了 urgency=medium,对于包含 bug 修复和功能更新的版本来说是合适的。
  • 提交信息规范
    • 使用了常见的 chore:, fix:, feat: 前缀来标记变更类型,这有助于快速理解变更的性质,值得肯定。
    • 每一条变更记录都清晰明了。

3. 代码逻辑与内容审查

虽然这是日志文件,不包含逻辑代码,但从日志内容可以推断出以下代码层面的潜在风险:

  • fix: initialize wireless other item expanded state
    • 逻辑/状态管理:提到初始化"无线其他项"的展开状态。建议确保在代码中,这个状态不仅在 UI 初始化时设置,还要在底层网络状态重置(如无线开关关闭再开启)时进行重置,防止状态残留导致 UI 显示不一致。
  • feat: add item move support
    • 用户体验/逻辑:增加了"项目移动支持"。这通常涉及拖拽功能。请务必确保:
      • 边界检查:防止将项目拖出有效区域。
      • 数据持久化:确保用户调整后的顺序在重启或注销后依然保留(通常写入配置文件)。
      • 并发安全:如果在拖拽过程中网络状态发生变化(如新设备出现),需要有处理逻辑防止数组越界或崩溃。
  • fix: remove left/right margin for dock-network-plugin
    • UI/兼容性:移除了边距。这通常是出于视觉设计的调整。建议测试在不同 DPI(缩放比例)和不同主题(深色/浅色)下的显示效果,确保没有出现控件被裁剪或间距过小导致难以点击的问题。

4. 性能与安全

  • chore: replace qWarning with categorized logging
    • 性能/调试:将 qWarning 替换为分类日志是一个好的实践。这允许运行时通过环境变量(如 QT_LOGGING_RULES)控制特定模块的日志输出级别,有助于在生产环境中减少不必要的日志 I/O 开销,同时在调试时能精准定位问题。
  • 安全性
    • 虽然日志变更本身不直接引入安全漏洞,但需注意不要在日志中打印敏感信息(如密码、密钥或 SSID 的原始密码)。既然涉及到 "secret agent improvements"(秘密代理改进),请确保新增的日志代码严格遵守这一原则。

总结建议

  1. 必须修改:将日期年份从 2026 修正为当前实际年份。
  2. 测试重点
    • 测试无线列表的展开/折叠状态在多次操作后的稳定性。
    • 测试拖拽排序功能是否稳定且能正确保存配置。
    • 测试 Dock 插件在移除边距后的视觉表现和交互可用性。
  3. 代码审查:针对 "secret agent" 相关代码,进行专门的安全审查,确保无敏感信息泄露。

@18202781743 18202781743 merged commit fb7ad92 into linuxdeepin:master Jan 15, 2026
17 of 19 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants