fix manifest start_url when using SUBFOLDER#162
Merged
Conversation
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
Member
|
Yeah baseimages are the wild west kind of there is no official versioning or changelogs: Might need to re-think that for Selkies, though clearly the goal is to never make breaking changes. |
thelamer
added a commit
that referenced
this pull request
May 22, 2026
thelamer
added a commit
that referenced
this pull request
May 22, 2026
thelamer
added a commit
that referenced
this pull request
May 22, 2026
thelamer
added a commit
that referenced
this pull request
May 22, 2026
thelamer
added a commit
that referenced
this pull request
May 22, 2026
thelamer
added a commit
that referenced
this pull request
May 22, 2026
thelamer
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix the
start_urlparameter for the PWA when SUBFOLDER is used.Benefits of this PR and context:
When using the
SUBFOLDERparameter of the docker image, the resulting PWA was using the wrong url when starting.How Has This Been Tested?
Then install the PWA (tested on chrome 131.0.6778.69, Fedora 44) , and launch it. I checked the resulting
manifest.jsonto look at thestart_url: /test/parameter.I also tested without
-e SUBFOLDER=/test/.Source / References:
https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Manifest/Reference/start_url
(by the way, didn't find the changelog in the repo)