Skip to content

Update default.conf.sample to deny dotfile access#68

Open
nemchik wants to merge 2 commits into
masterfrom
deny-dotfile-access
Open

Update default.conf.sample to deny dotfile access#68
nemchik wants to merge 2 commits into
masterfrom
deny-dotfile-access

Conversation

@nemchik
Copy link
Copy Markdown
Member

@nemchik nemchik commented Feb 8, 2026

No description provided.

Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.5-pkg-bb781617-dev-11c64b0b62181a630d7295f04afb889511b48631-pr-68/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.5-pkg-bb781617-dev-11c64b0b62181a630d7295f04afb889511b48631-pr-68/shellcheck-result.xml

Tag Passed
amd64-v2.3.5-pkg-bb781617-dev-11c64b0b62181a630d7295f04afb889511b48631-pr-68
arm64v8-v2.3.5-pkg-bb781617-dev-11c64b0b62181a630d7295f04afb889511b48631-pr-68

Signed-off-by: Eric Nemchik <eric@nemchik.com>
Copilot AI review requested due to automatic review settings May 5, 2026 21:42
@LinuxServer-CI LinuxServer-CI moved this from PRs to PRs Ready For Team Review in Issue & PR Tracker May 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the container’s sample Nginx site configuration to block access to hidden “dotfiles” (e.g., .env, .git), while documenting the change in the project changelog variables.

Changes:

  • Added a general Nginx rule to deny access to all dotfiles (with an explicit exception for /.well-known).
  • Removed the previous narrower deny rule that only blocked .ht* files.
  • Added a changelog entry in readme-vars.yml indicating existing users should update their Nginx site config.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
root/defaults/nginx/site-confs/default.conf.sample Adds dotfile blocking and a /.well-known exception; minor formatting cleanup.
readme-vars.yml Adds a changelog entry advising users to update Nginx config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

index index.html index.htm index.php;

# Allow access to the ".well-known" directory
location ^~ /.well-known {
Comment thread readme-vars.yml
"diskover:latest" <- Base Images
# changelog
changelogs:
- {date: "08.02.26:", desc: "Existing users should update: site-confs/default.conf - Deny access to all dotfiles."}
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.5-pkg-bb781617-dev-d081967f833a12630da8574df23df89125933c2e-pr-68/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.5-pkg-bb781617-dev-d081967f833a12630da8574df23df89125933c2e-pr-68/shellcheck-result.xml

Tag Passed
amd64-v2.3.5-pkg-bb781617-dev-d081967f833a12630da8574df23df89125933c2e-pr-68
arm64v8-v2.3.5-pkg-bb781617-dev-d081967f833a12630da8574df23df89125933c2e-pr-68

@LinuxServer-CI LinuxServer-CI moved this from PRs Ready For Team Review to PRs in Issue & PR Tracker May 5, 2026
@LinuxServer-CI
Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.5-pkg-0658ee9e-dev-cef42923c8d2410f2bede9e8b4b5afa6e21bcefe-pr-68/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.3.5-pkg-0658ee9e-dev-cef42923c8d2410f2bede9e8b4b5afa6e21bcefe-pr-68/shellcheck-result.xml

Tag Passed
amd64-v2.3.5-pkg-0658ee9e-dev-cef42923c8d2410f2bede9e8b4b5afa6e21bcefe-pr-68
arm64v8-v2.3.5-pkg-0658ee9e-dev-cef42923c8d2410f2bede9e8b4b5afa6e21bcefe-pr-68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants