Skip to content

webrtc-sys-build: disable zip default features#1061

Merged
ladvoc merged 2 commits into
livekit:mainfrom
astral-sh:charlie/drop-zip-default-features
May 20, 2026
Merged

webrtc-sys-build: disable zip default features#1061
ladvoc merged 2 commits into
livekit:mainfrom
astral-sh:charlie/drop-zip-default-features

Conversation

@charliermarsh
Copy link
Copy Markdown
Contributor

Summary

My understanding is that webrtc-sys-build needs the zip crate to extract the prebuilt WebRTC archives, which always use deflate. Trimming the default features removes a significant portion of the dependency tree.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 6, 2026

CLA assistant check
All committers have signed the CLA.

@charliermarsh charliermarsh marked this pull request as draft May 6, 2026 23:36
@charliermarsh charliermarsh force-pushed the charlie/drop-zip-default-features branch from d1ab35e to f25d0b3 Compare May 6, 2026 23:41
@charliermarsh charliermarsh marked this pull request as ready for review May 6, 2026 23:42
@ladvoc ladvoc self-requested a review May 8, 2026 17:24
@ladvoc
Copy link
Copy Markdown
Contributor

ladvoc commented May 8, 2026

@charliermarsh, thank you for your contribution. Please add the following changeset at .changeset/disable_default_features_for_zip_dependency.md:

---
webrtc-sys-build: patch
---

# Disable default features for zip dependency

@charliermarsh
Copy link
Copy Markdown
Contributor Author

Done, thank you.

@ladvoc ladvoc merged commit 7f47473 into livekit:main May 20, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants