[#2450] Add button(-modifier) tokens and bump version#8
Draft
jiromaykin wants to merge 2 commits intomainfrom
Draft
[#2450] Add button(-modifier) tokens and bump version#8jiromaykin wants to merge 2 commits intomainfrom
jiromaykin wants to merge 2 commits intomainfrom
Conversation
jiromaykin
force-pushed
the
feature/2450-nlds-npm-button-tokens
branch
from
9dfcdc6 to
cf3484e
Compare
jiromaykin
force-pushed
the
feature/2450-nlds-npm-button-tokens
branch
2 times, most recently
from
da26dd6 to
b0a0dcb
Compare
jiromaykin
force-pushed
the
feature/2450-nlds-npm-button-tokens
branch
from
dc02592 to
a60935f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2450
Utrecht buttons contain values that we do not have, so these need to be set to 'none' in OIP in order to get rid of that styling:
block-size: fit-content;
cursor: var(--utrecht-action-activate-cursor, revert);
font-weight: var(--_utrecht-button-appearance-font-weight, var(--utrecht-button-font-weight));
inline-size: var(--utrecht-button-inline-size, auto);
justify-content: center;
max-inline-size: var(--utrecht-button-max-inline-size, fit-content);
min-block-size: var(--utrecht-button-min-block-size, 44px);
min-inline-size: var(--utrecht-button-min-inline-size, 44px);
scale: 1;
text-transform: var(--utrecht-button-text-transform);
Explanation common tokens:
https://nldesignsystem.nl/handboek/design-tokens/#common-tokens
Vice versa:
in OIP we are using certain/extra attribute that are not set in Utrecht, dso we need extra OIP design tokens for these:
It' also easier to make more general tokens for spacing since we are using those in the entire project in the same way.
Deeper documentation, compare Den Haag to Utrecht:
https://nl-design-system.github.io/denhaag/?path=/docs/css-input-button--docs
https://nl-design-system.github.io/utrecht/storybook/?path=/docs/css-button-appearance--docs