[#3457] Filter eHerkenning zaken by KVK and vestigingsnummer#1936
Open
[#3457] Filter eHerkenning zaken by KVK and vestigingsnummer#1936
Conversation
pi-sigma
force-pushed
the
story/3457-kvk-filtering
branch
from
52e3e31 to
6e396f0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1936 +/- ##
========================================
Coverage 93.99% 93.99%
========================================
Files 1154 1154
Lines 44374 44414 +40
========================================
+ Hits 41708 41748 +40
Misses 2666 2666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zaken for eHerkenning users logged in as vestiging are now filtered by KVK as well as vestigingsnummer. The filtering is done client-side as the eSuite does not have a query parameter for this purpose. For contactmomenten/questions, this filtering only works for OpenKlant but not for eSuite as the latter does not support scoping of identifiers (i.e. looking for a vestigingsnummer that's related to a KVK). Refs: https://taiga.maykinmedia.nl/project/open-inwoner/us/3457
pi-sigma
force-pushed
the
story/3457-kvk-filtering
branch
from
6e396f0 to
7264a44
Compare
swrichards
reviewed
Sep 29, 2025
Collaborator
swrichards
left a comment
swrichards
left a comment
There was a problem hiding this comment.
Will await a new review request as we test the eSuite behavior as discussed.
| ) | ||
|
|
||
| raise ValueError("You must supply either a bsn or kvk/rsin/vestigingsnummer") | ||
| # return intesection of zaken for kvk and zaken for vestiging |
Collaborator
There was a problem hiding this comment.
Suggested change
| # return intesection of zaken for kvk and zaken for vestiging | |
| # return intersection of zaken for kvk and zaken for vestiging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zaken for eHerkenning users logged in as vestiging are now filtered by KVK as well as vestigingsnummer. The filtering is done client-side as the eSuite does not have a query parameter for this purpose.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/us/3457