feat: validate file length in zgw document download view#2248
Open
swrichards wants to merge 1 commit intodevelopfrom
Open
feat: validate file length in zgw document download view#2248swrichards wants to merge 1 commit intodevelopfrom
swrichards wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2248 +/- ##
========================================
Coverage 92.42% 92.42%
========================================
Files 1213 1213
Lines 47592 47605 +13
========================================
+ Hits 43985 43998 +13
Misses 3607 3607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If the ZGW document backend is misbehaving, for instance because an intermediate service gateway is broken and returns some kind of XML message, the user will see a broken download message, because the announced content-length will not in fact match the content. In those cases, it's better UX to log and display an error message. Closes: #2289
swrichards
force-pushed
the
extra-validation-document-download
branch
from
47c76bf to
2a12d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the ZGW document backend is misbehaving, for instance because
an intermediate service gateway is broken and returns some kind
of XML message, the user will see a broken download message,
because the announced content-length will not in fact match the
content. In those cases, it's better UX to log and display an
error message.